You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:15:08 UTC
[GitHub] [airflow] uranusjr opened a new pull request #21705: Fix stray order_by(TaskInstance.execution_date)
uranusjr opened a new pull request #21705:
URL: https://github.com/apache/airflow/pull/21705
Fix #21656.
Nobody noticed this exists because the function `BaseOperator.get_task_instances()` is not used anywhere in the code base. But since this is public API, we should still fix it.
A quick search for `order_by(TaskInstance.execution_date)` and `order_by(TI.execution_date)` yielded no other results; this is probably the only one we missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1048652445
`filter()` works, but not `order_by()`. There were other occurrences I fixed before 2.2 on this. It’s quite annoying (I would’ve said surprising but I know too much about SQLAlchemy to be surprised).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1046664198
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21705:
URL: https://github.com/apache/airflow/pull/21705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TidesMind commented on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
TidesMind commented on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1048064392
Thank you for fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1048613151
Change looks good, but I thought this would work through theh association_proxy anyway?
Obviously not by the error report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1048613151
Change looks good, but I thought this would work through theh association_proxy anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21705: Fix stray order_by(TaskInstance.execution_date)
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21705:
URL: https://github.com/apache/airflow/pull/21705#issuecomment-1048652445
`filter()` works, but not `order_by()`. There were other occurrences I fixed before 2.2 on this. It’s quite annoying (I would’ve said surprising but I know too much about SQLAlchemy to be).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org