You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Emmanuel Lécharny (Jira)" <ji...@apache.org> on 2023/06/22 07:45:00 UTC
[jira] [Moved] (SSHD-1330) keep-alive handler on client
[ https://issues.apache.org/jira/browse/SSHD-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lécharny moved DIRMINA-1174 to SSHD-1330:
--------------------------------------------------
Component/s: (was: Core)
Key: SSHD-1330 (was: DIRMINA-1174)
Project: MINA SSHD (was: MINA)
> keep-alive handler on client
> ----------------------------
>
> Key: SSHD-1330
> URL: https://issues.apache.org/jira/browse/SSHD-1330
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Florian Hof
> Priority: Minor
>
> After a connection using the default SFTP client, I get lot's of WARN logs like the following:
> {{handleUnknownRequest(ClientConnectionService[ClientSessionImpl[xxx@sftp-intern.xxx.com/xx.xx.xx.xx:993]]) unknown global request: keepalive@proftpd.org}}
> It seems that the server send keep-alive messages to the client. The {{[KeepAliveHandler|https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/global/KeepAliveHandler.java]}} handles this properly. It is per default in the server handlers. I propose to add it per default in the client handlers. This shouldn't have negative effect, should it? Adding it afterwards avoids the WARN logs.
> Implementation on {{[ClientBuilder.DEFAULT_GLOBAL_REQUEST_HANDLERS|https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/client/ClientBuilder.java#L69-L70]}} would be trivial:
> {code:java}
> public static final List<RequestHandler<ConnectionService>> DEFAULT_GLOBAL_REQUEST_HANDLERS
> = List.of(OpenSshHostKeysHandler.INSTANCE, KeepAliveHandler.INSTANCE);
> {code}
> (and eventually move the {{KeepAliveHandler}} from {{org.apache.sshd.*server*.global}} to {{{}org.apache.sshd.*common*.global{}}}).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org