[GitHub] spark pull request #22262: [SPARK-25175][SQL] Field resolution should fail i...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22262#discussion_r216119226
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ---
    @@ -116,6 +116,14 @@ object OrcUtils extends Logging {
             })
           } else {
             val resolver = if (isCaseSensitive) caseSensitiveResolution else caseInsensitiveResolution
    +        // Need to fail if there is ambiguity, i.e. more than one field is matched.
    +        requiredSchema.fieldNames.foreach { requiredFieldName =>
    +          val matchedOrcFields = orcFieldNames.filter(resolver(_, requiredFieldName))
    --- End diff --
    
    Sorry, @seancxmao . We need to update once more. I'll make a PR to you.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org