You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:26:29 UTC
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5326: Add toDateTime DateTimeFunction (#5313)
mcvsubbu commented on a change in pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#discussion_r419601234
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/function/DateTimeFunctions.java
##########
@@ -27,6 +32,8 @@
*/
public class DateTimeFunctions {
+ private Map<String, DateTimeFormatter> _dateTimeFormatterMap = new HashMap<>();
Review comment:
It seems to me that this should be a concurrent hashmap. Consumers from different partitions may call this across threads, am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org