You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/22 02:05:44 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #11347: KAFKA-13296: warn if previous assignment has duplicate partitions
mjsax commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r713232644
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -351,6 +351,17 @@ public GroupAssignment assign(final Cluster metadata, final GroupSubscription gr
// add the consumer and any info in its subscription to the client
clientMetadata.addConsumer(consumerId, subscription.ownedPartitions());
+ if (allOwnedPartitions.stream().anyMatch(t -> subscription.ownedPartitions().contains(t))) {
+ log.warn("The previous assignment contains a partition more than once. " +
+ "This might result in violation of EOS if enabled. \n" +
Review comment:
Not sure if we need to call out EOS in particular? It's incorrect in any case.
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -351,6 +351,17 @@ public GroupAssignment assign(final Cluster metadata, final GroupSubscription gr
// add the consumer and any info in its subscription to the client
clientMetadata.addConsumer(consumerId, subscription.ownedPartitions());
+ if (allOwnedPartitions.stream().anyMatch(t -> subscription.ownedPartitions().contains(t))) {
+ log.warn("The previous assignment contains a partition more than once. " +
+ "This might result in violation of EOS if enabled. \n" +
Review comment:
Wondering if we should print the full old-assignment a single time if we detect any error instead? Would be helpful to get the `client.id -> old-assignment` mapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org