[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3130: ARTEMIS-2757 improving flow control in AMQP

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3130:
URL: https://github.com/apache/activemq-artemis/pull/3130#discussion_r425371537



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
##########
@@ -496,15 +499,21 @@ public void serverSend(ProtonServerReceiverContext context,
             }
          } else {
             message.setConnectionID(receiver.getSession().getConnection().getRemoteContainer());
-            // We need to transfer IO execution to a different thread otherwise we may deadlock netty loop
-            sessionExecutor.execute(() -> inSessionSend(context, transaction, message, delivery, receiver, routingContext));
+            // If there are pending messages (durable) on the executors, we should still use the executors
+            // otherwise we risk running out of order
+            if (pendingSettles == 0 && !message.isDurable()) {

Review comment:
       This should fix your test... as this will guarantee no execution for non durable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org