You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/17 13:33:12 UTC
[GitHub] [doris] yixiutt opened a new pull request, #10946: [Bugfix](compaction) fix uniq key compaction bug
yixiutt opened a new pull request, #10946:
URL: https://github.com/apache/doris/pull/10946
One rowset multi segments in uniq key compaction, segments rows will be
merged in generic_iterator but merged_rows not increased。
Compaction will failed in check_correctness, and make a tablet with
too much versions which lead to -235 load error.
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10946:
URL: https://github.com/apache/doris/pull/10946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
yixiutt commented on code in PR #10946:
URL: https://github.com/apache/doris/pull/10946#discussion_r922928652
##########
be/src/olap/rowset/rowset_reader_context.h:
##########
@@ -64,6 +64,7 @@ struct RowsetReaderContext {
int batch_size = 1024;
bool is_vec = false;
bool is_unique = false;
+ uint64_t* merged_rows;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
yixiutt commented on code in PR #10946:
URL: https://github.com/apache/doris/pull/10946#discussion_r922838959
##########
be/src/vec/olap/vgeneric_iterators.cpp:
##########
@@ -374,6 +377,8 @@ Status VMergeIterator::next_batch(vectorized::Block* block) {
if (!ctx->need_skip()) {
// copy current row to block
ctx->copy_row(block);
+ } else {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10946:
URL: https://github.com/apache/doris/pull/10946#issuecomment-1186527627
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10946:
URL: https://github.com/apache/doris/pull/10946#discussion_r922927976
##########
be/src/olap/rowset/rowset_reader_context.h:
##########
@@ -64,6 +64,7 @@ struct RowsetReaderContext {
int batch_size = 1024;
bool is_vec = false;
bool is_unique = false;
+ uint64_t* merged_rows;
Review Comment:
```suggestion
uint64_t* merged_rows = nullptr;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10946:
URL: https://github.com/apache/doris/pull/10946#issuecomment-1186578999
Is it only for dev-1.1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
yixiutt commented on PR #10946:
URL: https://github.com/apache/doris/pull/10946#issuecomment-1186670497
>
also for master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #10946: [Bugfix](compaction) fix uniq key compaction bug
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #10946:
URL: https://github.com/apache/doris/pull/10946#discussion_r922838515
##########
be/src/vec/olap/vgeneric_iterators.cpp:
##########
@@ -374,6 +377,8 @@ Status VMergeIterator::next_batch(vectorized::Block* block) {
if (!ctx->need_skip()) {
// copy current row to block
ctx->copy_row(block);
+ } else {
Review Comment:
check `_merged_rows` not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org