You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 03:47:56 UTC
[GitHub] [doris] airborne12 opened a new pull request, #15807: [Update](deps) add clucene deps for doris inverted index
airborne12 opened a new pull request, #15807:
URL: https://github.com/apache/doris/pull/15807
# Proposed changes
As part of [Inverted Index DSIP](https://cwiki.apache.org/confluence/display/DORIS/DSIP-023%3A+Add+inverted+index+for+full+text+search) steps, we'd like to contribute our inverted index implementations step by step.
First of all we need to introduce clucene to doris thirdparty libs, because inverted index implementations are based on lucence API and index file format, also we add our features and performance improvements base on clucene, so we need to maintain the repo ourselves
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066624860
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
> It's not just a third-party lib, we added a lot features into it, sometimes we need ASAN to debug problems
Okay.
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
Review Comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1380003973
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066585485
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
Review Comment:
Yes, we use TurboPFor for integer compression which needs AVX2 compile flags to seperate different building arch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066570113
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
Using `CXXFLAGS` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066609007
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
> Only with RelWithDebInfo flags is not enough, CLucene also need to compile ASAN edition,
It is a third-party library, we can just use it. Why do we need ASAN build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066636875
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1378214951
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1379348497
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.14 seconds
load time: 492 seconds
storage size: 17122179885 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111190005_clickbench_pr_78059.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1378475567
It seems that we need an extra works to port the library CLucene to macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066569070
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${BUILD_SYSTEM} -j "${PARALLEL}" && ${BUILD_SYSTEM} install
+ elif [[ "${CC}" == *clang ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
Review Comment:
Looks verbose. It can be simplified like
```shell
${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
-DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}"
-DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DBUILD_CONTRIBS_LIB=ON ..
${BUILD_SYSTEM} -j "${PARALLEL}"
${BUILD_SYSTEM} install
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1378627865
>
Yeah, also noticed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1378214976
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066644368
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
By the way, CMake don't provide `ASAN` build type by default. You would better add `-g` to these variables ([CXX_FLAGS_ASAN](https://github.com/apache/doris-thirdparty/blob/clucene/CMakeLists.txt#L120) and [CXX_FLAGS_LSAN](https://github.com/apache/doris-thirdparty/blob/clucene/CMakeLists.txt#L121)) in `CMakeLists.txt` of [clucene](https://github.com/apache/doris-thirdparty/tree/clucene).
Examples:
```CMakeLists.txt
if (__COMPILER_CLANG)
SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=address -DADDRESS_SANITIZER")
SET(CXX_FLAGS_LSAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=leak -DLEAK_SANITIZER")
else ()
SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=address -DADDRESS_SANITIZER -static-libasan")
SET(CXX_FLAGS_LSAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=leak -DLEAK_SANITIZER -static-liblsan")
endif ()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066624860
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
> It's not just a third-party lib, we added a lot features into it, sometimes we need ASAN to debug problems
Okey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15807:
URL: https://github.com/apache/doris/pull/15807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066568186
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
This block can be omitted. Just pass `-DCMAKE_BUILD_TYPE=RelWithDebInfo` to CMake.
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${BUILD_SYSTEM} -j "${PARALLEL}" && ${BUILD_SYSTEM} install
+ elif [[ "${CC}" == *clang ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
Review Comment:
Looks verbose. The following common part can be separated like
```shell
${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
-DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}"
-DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DBUILD_CONTRIBS_LIB=ON ..
${BUILD_SYSTEM} -j "${PARALLEL}"
${BUILD_SYSTEM} install
```
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
It is better to use a variable like `warning_narrowing`. See [L144](https://github.com/apache/doris/blob/master/thirdparty/build-thirdparty.sh#L144)
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
Using `CXX_FLAGS` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066654525
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
Already done that in CLucene, thanks a lot~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066572527
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
Review Comment:
Is the variable needed in CLucene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066582693
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
Only with RelWithDebInfo flags is not enough, CLucene also need to compile ASAN edition,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066569070
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${BUILD_SYSTEM} -j "${PARALLEL}" && ${BUILD_SYSTEM} install
+ elif [[ "${CC}" == *clang ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
Review Comment:
Looks verbose. The common part can be separated like
```shell
${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
-DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}"
-DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DBUILD_CONTRIBS_LIB=ON ..
${BUILD_SYSTEM} -j "${PARALLEL}"
${BUILD_SYSTEM} install
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066569070
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${BUILD_SYSTEM} -j "${PARALLEL}" && ${BUILD_SYSTEM} install
+ elif [[ "${CC}" == *clang ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
Review Comment:
Looks verbose. It can be simplified like
```shell
${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
-DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}" \
-DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DBUILD_CONTRIBS_LIB=ON ..
${BUILD_SYSTEM} -j "${PARALLEL}"
${BUILD_SYSTEM} install
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066637123
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${BUILD_SYSTEM} -j "${PARALLEL}" && ${BUILD_SYSTEM} install
+ elif [[ "${CC}" == *clang ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-c++11-narrowing" \
+ ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
+ -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
Review Comment:
done, good suggestion, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066644368
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
+ check_if_source_exist "${CLUCENE_SOURCE}"
+ cd "${TP_SOURCE_DIR}/${CLUCENE_SOURCE}"
+ mkdir -p "${BUILD_DIR}" && cd "${BUILD_DIR}"
+ rm -rf CMakeCache.txt CMakeFiles/
+
+ if [[ "${CC}" == *gcc ]]; then
+ CPPFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
+ CXXFLAGS="-fno-omit-frame-pointer -g -Wno-narrowing" \
Review Comment:
By the way, CMake doesn't provide `ASAN` build type by default. You would better add `-g` to these variables ([CXX_FLAGS_ASAN](https://github.com/apache/doris-thirdparty/blob/clucene/CMakeLists.txt#L120) and [CXX_FLAGS_LSAN](https://github.com/apache/doris-thirdparty/blob/clucene/CMakeLists.txt#L121)) in `CMakeLists.txt` of [clucene](https://github.com/apache/doris-thirdparty/tree/clucene).
Examples:
```CMakeLists.txt
if (__COMPILER_CLANG)
SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=address -DADDRESS_SANITIZER")
SET(CXX_FLAGS_LSAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=leak -DLEAK_SANITIZER")
else ()
SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=address -DADDRESS_SANITIZER -static-libasan")
SET(CXX_FLAGS_LSAN "${CXX_GCC_FLAGS} -O0 -g -fsanitize=leak -DLEAK_SANITIZER -static-liblsan")
endif ()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15807:
URL: https://github.com/apache/doris/pull/15807#issuecomment-1378343483
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066607911
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
Review Comment:
Okey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066585485
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
Review Comment:
Yes, we use TurboPFor for integer compression which need AVX2 compile flags to seperate different building arch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15807: [Update](deps) add clucene deps for doris inverted index
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15807:
URL: https://github.com/apache/doris/pull/15807#discussion_r1066621178
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1545,12 +1545,43 @@ build_concurrentqueue() {
cp ./*.h "${TP_INSTALL_DIR}/include/"
}
+#clucene
+build_clucene() {
+ if [[ -z ${USE_AVX2} ]]; then
+ USE_AVX2=1
+ fi
+ if [[ -z ${BUILD_TYPE} ]]; then
+ BUILD_TYPE=Release
+ fi
Review Comment:
It's not just a third-party lib, we added a lot features into it, sometimes we need ASAN to debug problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org