You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org> on 2011/07/25 23:54:11 UTC
[jira] [Created] (PIG-2191) Reduce amount of log spam generated by
UDFs
Reduce amount of log spam generated by UDFs
-------------------------------------------
Key: PIG-2191
URL: https://issues.apache.org/jira/browse/PIG-2191
Project: Pig
Issue Type: Bug
Reporter: Dmitriy V. Ryaboy
Assignee: Dmitriy V. Ryaboy
Fix For: 0.10
Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2191) Reduce amount of log spam generated by
UDFs
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2191:
-----------------------------------
Status: Patch Available (was: Open)
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2191) Reduce amount of log spam generated by
UDFs
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2191:
-----------------------------------
Attachment: PIG-2191.2.patch
Attaching a version that actually compiles.. forgot some imports last time.
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.2.patch, PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2191) Reduce amount of log spam generated
by UDFs
Posted by "Prashant Kommireddi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230961#comment-13230961 ]
Prashant Kommireddi commented on PIG-2191:
------------------------------------------
@Thejas, is there a JIRA to support separate warning counters across multiple UDFs?
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.2.patch, PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (PIG-2191) Reduce amount of log spam generated by
UDFs
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy closed PIG-2191.
----------------------------------
Committed to trunk. Thanks for the review.
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.2.patch, PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2191) Reduce amount of log spam generated
by UDFs
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080260#comment-13080260 ]
Thejas M Nair commented on PIG-2191:
------------------------------------
+1 .
If there are multiple udfs being used in a pig script, it will be very useful to have different warning counters for each of them. I will create a jira to support that feature and link it to this jira.
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.2.patch, PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2191) Reduce amount of log spam generated
by UDFs
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071459#comment-13071459 ]
Raghu Angadi commented on PIG-2191:
-----------------------------------
looks good.
- JsonMetadata.java changes seem unrelated (whitespace only).
- +1 for making deprecated classes just extend the non-deprecated ones.
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2191) Reduce amount of log spam generated by
UDFs
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2191:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.2.patch, PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2191) Reduce amount of log spam generated by
UDFs
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2191:
-----------------------------------
Attachment: PIG-2191.patch
Attaching the patch. No unit tests, since the previous tests are sufficient.
While I was in there, I changed the deprecated piggybank funcs that had this problem to be empty shells for their builtin variants.
Please review.
> Reduce amount of log spam generated by UDFs
> -------------------------------------------
>
> Key: PIG-2191
> URL: https://issues.apache.org/jira/browse/PIG-2191
> Project: Pig
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.10
>
> Attachments: PIG-2191.patch
>
>
> Many builtin UDFs use log.warn instead of warn() to report warnings. This can produce an inordinate and unneeded amount of error logging. The warn() method is provided to aggregate that sort of thing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira