You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/07 08:45:33 UTC

[GitHub] [pulsar] lhotari opened a new pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

lhotari opened a new pull request #14576:
URL: https://github.com/apache/pulsar/pull/14576


   ### Motivation
   
   - see https://github.com/netty/netty/commit/9fe97103 which renamed the property `io.netty.recycler.maxCapacity.default` to `io.netty.recycler.maxCapacity` in 2014 for netty-4.1.0.Beta1
   - current implementation in https://github.com/netty/netty/blob/51eda20432568ffdf736a673abc6b5a44839413f/common/src/main/java/io/netty/util/Recycler.java#L62-L90 used `io.netty.recycler.maxCapacityPerThread` as the primary setting and falls back to `io.netty.recycler.maxCapacity`
   
   ### Modifications
   
   - Remove `-Dio.netty.recycler.maxCapacity.default=1000` settings since there has been no impact of this setting. It would be a breaking change to set the correct setting to the value of 1000. Therefore it's better to simply drop the invalid property name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] michaeljmarshall commented on pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14576:
URL: https://github.com/apache/pulsar/pull/14576#issuecomment-1060994439


   @lhotari - this appears to conflict with https://github.com/apache/pulsar/pull/13563. Can you take a look to see how we can/should integrate the two PRs? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari closed pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #14576:
URL: https://github.com/apache/pulsar/pull/14576


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14576:
URL: https://github.com/apache/pulsar/pull/14576#issuecomment-1061419453


   > @lhotari - this appears to conflict with #13563. Can you take a look to see how we can/should integrate the two PRs? Thanks.
   
   Thanks for letting me know. Yes, that PR can replace this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org