[GitHub] sven-lange-last commented on a change in pull request #3193: No automatic topic creation in Kafka

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #3193: No automatic topic creation in Kafka
URL: https://github.com/apache/incubator-openwhisk/pull/3193#discussion_r162088112
 
 

 ##########
 File path: ansible/roles/kafka/tasks/deploy.yml
 ##########
 @@ -23,6 +23,7 @@
       "KAFKA_HEAP_OPTS": "-Xmx{{ kafka.heap }} -Xms{{ kafka.heap }}"
       "KAFKA_ZOOKEEPER_CONNECT": "{{ zookeeper_connect_string }}"
       "KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR": "{{ kafka.replicationFactor }}"
+      "KAFKA_AUTO_CREATE_TOPICS_ENABLE": "{{ kafka.autoCreateTopics }}"
 
 Review comment:
   That's fair. I'm removing the code to make this configurable and will simply switch automatic topic creation off. The default is `off` anyway and no Ansible environment has it `on`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services