You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/01/23 02:31:59 UTC

[kudu-CR] python: fix Python 3.4 based tests 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12255


Change subject: python: fix Python 3.4 based tests
......................................................................

python: fix Python 3.4 based tests

Pip released 19.0 recently and tests based on Python 3.4 started to fail
with ImportError. In addition, Python 3.4 will no longer supported
starting from pip 19.1. Therefore, this patch updates the pip version
to the last one that works.

Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
---
M build-support/jenkins/build-and-test.sh
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12255/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 )

Change subject: python: fix Python 3.4 based tests
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG@9
PS1, Line 9: Pip released 19.0 recently and tests based on Python 3.4 started to fail
           : with ImportError
Would be good to include the error message in fail, to help searching in the future.


http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh@518
PS1, Line 518:   # Even though Python 3.4 is no longer supported starting from pip 19.1, attempting
             :   # to upgrade to pip 19.0 on Python 3.4 with pandas 0.22 yields errors. Therefore,
             :   # pin to the last pip version that works.
I filed an upstream bug with pip: https://github.com/pypa/pip/issues/6175. Could you reword to link to that bug report, so that we'll have more information? Something like:

  # new version of pip to proceed.
  #
  # pip 19.1 doesn't support Python 3.4, which is the version of Python 3
  # shipped with Ubuntu 14.04. However, there appears to be a bug[1] in pip 19.0
  # preventing it from working properly with Python 3.4 as well. Therefore we
  # must pin to a pip version from before 19.0.
  #
  # 1. https://github.com/pypa/pip/issues/6175



-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 06:53:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: python: fix Python 3.4 based tests
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 )

Change subject: python: fix Python 3.4 based tests
......................................................................


Patch Set 2: Verified+1

Overriding Jenkins. The build failures were due to thirdparty changes in Grant's Docker change (https://gerrit.cloudera.org/c/12173/), and since PS2 was a comment-only change and PS1 passed, it should build fine too.


-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 17:35:30 +0000
Gerrit-HasComments: No

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 )

Change subject: python: fix Python 3.4 based tests
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Addressed my own feedback in PS2.

http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG@9
PS1, Line 9: Pip released 19.0 recently and tests based on Python 3.4 started to fail. In
           : addition, Python
> Would be good to include the error message in fail, to help searching in th
Done


http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh@518
PS1, Line 518:   #
             :   # pip 19.1 doesn't support Python 3.4, which is the version of Python 3
             :   # shipped with Ubuntu 14.04. However, the
> I filed an upstream bug with pip: https://github.com/pypa/pip/issues/6175. 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 07:13:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12255 )

Change subject: python: fix Python 3.4 based tests
......................................................................

python: fix Python 3.4 based tests

Pip released 19.0 recently and tests based on Python 3.4 started to fail. In
addition, Python 3.4 will no longer be supported beginning with pip 19.1.
Therefore, this patch updates the pip version to the last one that works.

The full error message is below.

  $ pip install pandas
  DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).
  Collecting pandas
    Using cached https://files.pythonhosted.org/packages/08/01/803834bc8a4e708aedebb133095a88a4dad9f45bbaf5ad777d2bea543c7e/pandas-0.22.0.tar.gz
    Installing build dependencies ... done
    Getting requirements to build wheel ... error
    Complete output from command /home/jenkins-slave/a/bin/python3 /home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpsknqc6o3:
    Traceback (most recent call last):
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
        main()
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
        json_out['return_val'] = hook(**hook_input['kwargs'])
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 54, in get_requires_for_build_wheel
        return hook(config_settings)
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 115, in get_requires_for_build_wheel
        return _get_build_requires(config_settings, requirements=['wheel'])
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 101, in _get_build_requires
        _run_setup()
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 85, in _run_setup
        exec(compile(code, __file__, 'exec'), locals())
      File "setup.py", line 27, in <module>
        import versioneer
    ImportError: No module named 'versioneer'

Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Reviewed-on: http://gerrit.cloudera.org:8080/12255
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] python: fix Python 3.4 based tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#2) to the change originally created by Hao Hao. ( http://gerrit.cloudera.org:8080/12255 )

Change subject: python: fix Python 3.4 based tests
......................................................................

python: fix Python 3.4 based tests

Pip released 19.0 recently and tests based on Python 3.4 started to fail. In
addition, Python 3.4 will no longer be supported beginning with pip 19.1.
Therefore, this patch updates the pip version to the last one that works.

The full error message is below.

  $ pip install pandas
  DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).
  Collecting pandas
    Using cached https://files.pythonhosted.org/packages/08/01/803834bc8a4e708aedebb133095a88a4dad9f45bbaf5ad777d2bea543c7e/pandas-0.22.0.tar.gz
    Installing build dependencies ... done
    Getting requirements to build wheel ... error
    Complete output from command /home/jenkins-slave/a/bin/python3 /home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpsknqc6o3:
    Traceback (most recent call last):
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 207, in <module>
        main()
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 197, in main
        json_out['return_val'] = hook(**hook_input['kwargs'])
      File "/home/jenkins-slave/a/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py", line 54, in get_requires_for_build_wheel
        return hook(config_settings)
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 115, in get_requires_for_build_wheel
        return _get_build_requires(config_settings, requirements=['wheel'])
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 101, in _get_build_requires
        _run_setup()
      File "/tmp/pip-build-env-z5ha9gs9/overlay/lib/python3.4/site-packages/setuptools/build_meta.py", line 85, in _run_setup
        exec(compile(code, __file__, 'exec'), locals())
      File "setup.py", line 27, in <module>
        import versioneer
    ImportError: No module named 'versioneer'

Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
---
M build-support/jenkins/build-and-test.sh
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/12255/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12255
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95
Gerrit-Change-Number: 12255
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)