You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by panarasi <gi...@git.apache.org> on 2014/04/03 23:16:33 UTC
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
GitHub user panarasi opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26
Add pickContact functionality to cordova contacts plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts pickContact
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit d656191c4072cbef0bf5b3b5f5eb4dfe4817d25b
Author: Vladimir Kotikov <vl...@akvelon.com>
Date: 2014-04-02T06:38:12Z
Add pickContact functionality to cordova contacts plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-40952530
Please also add a JIRA issue for this new feature: http://issues.apache.org/jira/browse/CB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-40952397
Hi, there are still references to "Copyright Microsoft Open Technologies" in some of the files still (even with the latest commit). For this to be pulled in, all of those copyright references must be removed, follow guidelines here: https://www.apache.org/legal/src-headers.html#headers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by AleksMeshkov <gi...@git.apache.org>.
Github user AleksMeshkov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46529001
Hi to all! Have anyone noticed bug with getting wrong contact instance? When I run code below I get contact instance witch I didn't pick. When I select "Mom" in picker's interface I get, for example, "Dmitri". It happens on Android 4.3 and 4.4.3.
```
navigator.contacts.pickContact(function (contact) {
if (contact.id == -1) {
return false;
}
alert(contact.name.formatted);
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by JohnMcLear <gi...@git.apache.org>.
Github user JohnMcLear commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#discussion_r11273332
--- Diff: src/android/ContactInfoDTO.java ---
@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc. Licensed under the Apache License, Version 2.0 (the "License").
--- End diff --
Follow same format as other license declerations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46621747
Please file an issue at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and you can be notified.
Sign up here:
https://issues.apache.org/jira/secure/Signup!default.jspa
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-43013866
Firefox OS did not change, once this is merged I'll file a bug for us to add the functionality there too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44281909
Is there any work left here before we can merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44308005
I think we're good. Do you want to merge it @sgrebnov?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-40956290
I think it makes sense for the pickContact to at least support the `multiple` option. It should be available on all platforms.
Also, I am not sure why the original `seach` method on windows8 now returns an error, I think it made sense to show a contact picker if search functionality is not available on the platform. ( with documented quirks ... )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44455699
Thx @purplecabbage . I've tested merged version and confirm it works correct on Android, iOS, WP8, Windows8,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41142820
Created a separate JIRA enhancement for 'multiple' option: https://issues.apache.org/jira/browse/CB-6499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by axemclion <gi...@git.apache.org>.
Github user axemclion commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41073386
@purplecabbage About the `multiple` options, it is not supported on Android. It can be implemented for iOS, but can that be a separate pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41194815
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41075134
Yeah, they are different, I think you're right to keep them that way.
Re:multiple, separate pull req is fine. Jira enhancement?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41046721
https://issues.apache.org/jira/browse/CB-6485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-43000931
This looks good to me. How are we on firefoxos, android(s), ubuntu and blackberry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by axemclion <gi...@git.apache.org>.
Github user axemclion commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41073195
@purplecabbage I think search and pick contact are 2 different things. On WIndows8, search is not supported. It would be a cause of confusion if we make search do pickContact, when it means something else on other platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41175017
Seems we are good now. @purplecabbage, @shazron is there anything else required before we can merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by AleksMeshkov <gi...@git.apache.org>.
Github user AleksMeshkov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46755984
https://issues.apache.org/jira/browse/CB-7003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41050221
Updated license headers due to https://www.apache.org/legal/src-headers.html#headers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by AleksMeshkov <gi...@git.apache.org>.
Github user AleksMeshkov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46750676
@shazron thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41418136
I've added minor update to WP8 code to populate 'photos' fields. This functionality was missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---