You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Maksim Zhuravkov (Jira)" <ji...@apache.org> on 2023/09/06 14:37:00 UTC

[jira] [Commented] (IGNITE-20239) Sql. Remove row type transformations from SetOpConverterRule.

    [ https://issues.apache.org/jira/browse/IGNITE-20239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762417#comment-17762417 ] 

Maksim Zhuravkov commented on IGNITE-20239:
-------------------------------------------

[~korlov], [~xtern]. Could you please review this PR?

> Sql. Remove row type transformations from SetOpConverterRule. 
> --------------------------------------------------------------
>
>                 Key: IGNITE-20239
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20239
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Maksim Zhuravkov
>            Assignee: Maksim Zhuravkov
>            Priority: Minor
>              Labels: ignite-3
>             Fix For: 3.0.0-beta2
>
>
> `SetOpConverterRule` creates a rowType produced by set operation by means of  `TypeFactory::leastRestrictive`. This should not be necessary because types of rows returned by inputs to set operation should be coerced at the validation stage by `SqlValidator`/ SetopOperandTypeChecker`. 
> Remove calls to `TypeFactory::leastRestrictive` from `SetOpConverterRule` for both colocated and map/reduce versions of operators and use `rowType` returned by a set operator node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)