You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/11/23 01:15:14 UTC
[PR] [improve](move-memtable) improve logging messages [doris]
kaijchen opened a new pull request, #27443:
URL: https://github.com/apache/doris/pull/27443
## Proposed changes
Mainly add load id for easier debugging.
Also tweaked formatting and wording.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823785902
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823785875
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823715551
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823769972
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 888b6fc63689528abfaf9f8f6de680420c3df1c8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4903 4676 4613 4613
q2 354 139 166 139
q3 2035 1941 1929 1929
q4 1385 1256 1253 1253
q5 3987 3962 4055 3962
q6 248 126 127 126
q7 1443 882 882 882
q8 2777 2800 2788 2788
q9 9747 10312 9455 9455
q10 3456 3505 3516 3505
q11 373 241 234 234
q12 435 291 288 288
q13 4567 3821 3810 3810
q14 309 287 285 285
q15 588 528 558 528
q16 668 586 588 586
q17 1139 973 905 905
q18 7831 7484 7340 7340
q19 1668 1695 1660 1660
q20 561 301 308 301
q21 4414 3974 3986 3974
q22 472 385 366 366
Total cold run time: 53360 ms
Total hot run time: 48929 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4600 4560 4586 4560
q2 346 217 280 217
q3 4035 4008 4008 4008
q4 2701 2710 2695 2695
q5 9655 9565 9576 9565
q6 249 124 123 123
q7 3015 2505 2463 2463
q8 4473 4447 4467 4447
q9 12881 12790 12807 12790
q10 4089 4155 4181 4155
q11 803 655 645 645
q12 966 802 826 802
q13 4291 3598 3578 3578
q14 371 379 344 344
q15 573 517 514 514
q16 746 654 684 654
q17 3827 3833 3937 3833
q18 9596 9108 9059 9059
q19 1819 1763 1789 1763
q20 2398 2064 2087 2064
q21 8722 8607 8610 8607
q22 857 799 790 790
Total cold run time: 81013 ms
Total hot run time: 77676 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823718278
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823775053
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.18 seconds
stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17103852584 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #27443:
URL: https://github.com/apache/doris/pull/27443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823719291
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823716249
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) improve logging messages [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27443:
URL: https://github.com/apache/doris/pull/27443#issuecomment-1823751877
TeamCity be ut coverage result:
Function Coverage: 36.56% (8448/23107)
Line Coverage: 28.86% (68670/237956)
Region Coverage: 27.82% (35516/127641)
Branch Coverage: 24.56% (18119/73772)
Coverage Report: http://coverage.selectdb-in.cc/coverage/888b6fc63689528abfaf9f8f6de680420c3df1c8_888b6fc63689528abfaf9f8f6de680420c3df1c8/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org