[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7661: [DO NOT MERGE] Release testing record merger

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #7661:
URL: https://github.com/apache/hudi/pull/7661#discussion_r1081969266


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -599,21 +600,22 @@ private void flushToDiskIfRequired(HoodieRecord record, boolean appendDeleteBloc
     }
   }
 
-  private HoodieLogBlock.HoodieLogBlockType pickLogDataBlockFormat() {
-    Option<HoodieLogBlock.HoodieLogBlockType> logBlockTypeOpt = config.getLogDataBlockFormat();
+  public static HoodieLogBlock.HoodieLogBlockType pickLogDataBlockFormat(HoodieWriteConfig cfg, HoodieFileFormat format) {

Review Comment:
   We should move this method to write config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org