[jira] [Comment Edited] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

["Levani Kokhreidze (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082619#comment-17082619 ] 

Levani Kokhreidze edited comment on KAFKA-9859 at 4/13/20, 7:55 PM:
--------------------------------------------------------------------

Ah sorry, I think this ticket is a bit misleading. Kafka broker I have tested this was 2.3.1 and FK join was implemented in 2.4. Seems like 2.4.0 has proper implementation around topics generated by the FK Join, see `kafka.tools.StreamsResetter#isInternalTopic`. I guess this ticket can be closed as "not a problem"? Pretty sure streams-resetter on older versions of brokers can't be backward compatible with the FK join feature.


was (Author: lkokhreidze):
Ah sorry, I think this ticket is a bit misleading. Kafka broker I have tested this was 2.3.1 and FK join was implemented in 2.4. Seems like 2.4.0 has proper implementation around topics generated by the FK Join, see `kafka.tools.StreamsResetter#isInternalTopic`. I guess this ticket can be closed as "not a problem"? Not sure if older versions of brokers can be backward compatible with this. 

> kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-9859
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9859
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams, tools
>            Reporter: Levani Kokhreidze
>            Priority: Major
>
> Steps to reproduce:
>  * Create Kafka Streams application which uses foreign key join operation
>  * Stop Kafka streams application
>  * Perform `kafka-topics-list` and verify that foreign key operation internal topics are generated
>  * Use `kafka-streams-application-reset` to perform the cleanup of your kafka streams application: `kafka-streams-application-reset --application-id <your_app_id> --input-topics <your_input_topic> --bootstrap-servers <your_bootstrap_server> --to-datetime 2019-04-13T00:00:00.000`
>  * Perform `kafka-topics-list` again, you'll see that topics generated by the foreign key operation are still there.
> `kafka-streams-application-reset` uses `repartition` and `changelog` suffixes to determine which topics needs to be deleted, as a result topics generated by the foreign key are ignored.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)