You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lindenh (via GitHub)" <gi...@apache.org> on 2023/08/28 13:45:43 UTC
[GitHub] [superset] lindenh opened a new pull request, #25102: fix(dashboard): Dashboard import commands not correctly replacing charts
lindenh opened a new pull request, #25102:
URL: https://github.com/apache/superset/pull/25102
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Similar to https://github.com/apache/superset/pull/22208, the dashboard import commands would not replace charts when the overwrite flag was true, charts would be merged into one dashboard. This change fixes the command in the exact same way as that PR.
Fixes #22127
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
1. Create a dashboard with a chart.
2. Export the dashboard for import later.
3. Modify the dashboard to remove the first chart and add a new one.
4. Import the saved dashboard earlier (via UI OR /api/v1/dashboard/import)
5. Notice both charts are in the dashboard
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/22127
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lindenh commented on pull request #25102: fix(dashboard): Dashboard import commands not correctly replacing charts
Posted by "lindenh (via GitHub)" <gi...@apache.org>.
lindenh commented on PR #25102:
URL: https://github.com/apache/superset/pull/25102#issuecomment-1697767990
Done, sorry about that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mdeshmu commented on pull request #25102: fix(dashboard): Dashboard import commands not correctly replacing charts
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #25102:
URL: https://github.com/apache/superset/pull/25102#issuecomment-1696709025
Please fix pre-commit by running `pre-commit run --all-files`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org