You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/05 09:45:50 UTC
[GitHub] [spark] beliefer opened a new pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
beliefer opened a new pull request #33216:
URL: https://github.com/apache/spark/pull/33216
### What changes were proposed in this pull request?
This PR improve some implement for Spark.
### Why are the changes needed?
This PR improve some implement for Spark.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
Jenkins test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874053205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876967587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #33216:
URL: https://github.com/apache/spark/pull/33216#discussion_r666652043
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala
##########
@@ -37,7 +37,7 @@ import org.apache.spark.sql.catalyst.rules.Rule
class ExperimentalMethods private[sql]() {
/**
- * Allows extra strategies to be injected into the query planner at runtime. Note this API
Review comment:
I reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875545122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875470291
**[Test build #140752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140752/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876967587
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140835/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873984513
**[Test build #140654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140654/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873978584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875090497
**[Test build #140703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140703/testReport)** for PR 33216 at commit [`60f804b`](https://github.com/apache/spark/commit/60f804b1c99bc27ab326055fc7b078544fa444d3).
* This patch **fails from timeout after a configured wait of `500m`**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875109621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140703/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875441890
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876897756
**[Test build #140835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140835/testReport)** for PR 33216 at commit [`19b516f`](https://github.com/apache/spark/commit/19b516f27c9ab8479b6b47764b63d2fd799d5b30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875470291
**[Test build #140752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140752/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873982849
**[Test build #140650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140650/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873983321
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875382279
**[Test build #140747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140747/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873982918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876088181
ping @srowen Could you help me to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875441942
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875344831
**[Test build #140745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140745/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874281607
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876924668
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45346/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876939978
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45346/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #33216:
URL: https://github.com/apache/spark/pull/33216#discussion_r665857484
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala
##########
@@ -37,7 +37,7 @@ import org.apache.spark.sql.catalyst.rules.Rule
class ExperimentalMethods private[sql]() {
/**
- * Allows extra strategies to be injected into the query planner at runtime. Note this API
Review comment:
I removed a blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874739404
**[Test build #140703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140703/testReport)** for PR 33216 at commit [`60f804b`](https://github.com/apache/spark/commit/60f804b1c99bc27ab326055fc7b078544fa444d3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874046141
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #33216:
URL: https://github.com/apache/spark/pull/33216#discussion_r666652043
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala
##########
@@ -37,7 +37,7 @@ import org.apache.spark.sql.catalyst.rules.Rule
class ExperimentalMethods private[sql]() {
/**
- * Allows extra strategies to be injected into the query planner at runtime. Note this API
Review comment:
I have reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875348691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140745/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #33216:
URL: https://github.com/apache/spark/pull/33216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875358289
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-877305048
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875545122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873984513
**[Test build #140654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140654/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874016369
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45160/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875109621
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140703/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874768818
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45214/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875528844
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873983321
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875381768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876939978
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45346/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874010841
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45160/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875344831
**[Test build #140745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140745/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875380605
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875507291
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45264/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873982918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875348691
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140745/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875381768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45256/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874016369
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45160/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875386691
**[Test build #140747 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140747/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874739404
**[Test build #140703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140703/testReport)** for PR 33216 at commit [`60f804b`](https://github.com/apache/spark/commit/60f804b1c99bc27ab326055fc7b078544fa444d3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875386728
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874281607
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140654/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875584961
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140752/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873978584
**[Test build #140650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140650/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875441942
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874272169
**[Test build #140654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140654/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
* This patch **fails from timeout after a configured wait of `500m`**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874053205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875584961
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140752/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875582820
**[Test build #140752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140752/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875463755
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873978584
**[Test build #140650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140650/testReport)** for PR 33216 at commit [`0c0c904`](https://github.com/apache/spark/commit/0c0c904405f70426711aae37269e9d6a25ebc9a4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873982918
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876958743
**[Test build #140835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140835/testReport)** for PR 33216 at commit [`19b516f`](https://github.com/apache/spark/commit/19b516f27c9ab8479b6b47764b63d2fd799d5b30).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875386728
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140747/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874784435
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45214/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873982918
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140650/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875348655
**[Test build #140745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140745/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #33216:
URL: https://github.com/apache/spark/pull/33216#discussion_r665856871
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala
##########
@@ -37,7 +37,7 @@ import org.apache.spark.sql.catalyst.rules.Rule
class ExperimentalMethods private[sql]() {
/**
- * Allows extra strategies to be injected into the query planner at runtime. Note this API
Review comment:
This isn't necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875416887
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45258/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876897756
**[Test build #140835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140835/testReport)** for PR 33216 at commit [`19b516f`](https://github.com/apache/spark/commit/19b516f27c9ab8479b6b47764b63d2fd799d5b30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875382279
**[Test build #140747 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140747/testReport)** for PR 33216 at commit [`e73ff10`](https://github.com/apache/spark/commit/e73ff10f124eb84693cf62938925b24d0cfbe679).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #33216:
URL: https://github.com/apache/spark/pull/33216#discussion_r666150173
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala
##########
@@ -37,7 +37,7 @@ import org.apache.spark.sql.catalyst.rules.Rule
class ExperimentalMethods private[sql]() {
/**
- * Allows extra strategies to be injected into the query planner at runtime. Note this API
Review comment:
Right, I'm saying it doesn't help anything. I'd avoid changes that don't do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-876912583
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45346/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874784435
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45214/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-877779537
@srowen Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-874712348
Why are these improvements? there's no detail here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-875345385
> Why are these improvements? there's no detail here
I found some code seems a little issue. This PR just to make it more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33216:
URL: https://github.com/apache/spark/pull/33216#issuecomment-873978584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org