You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Jack, Paul" <pj...@sfaf.org> on 2002/06/19 00:11:56 UTC
[PATCH][Collections] TestList
Okay, this shouldn't be as difficult as the previous patches.
The TestList tests have been rewritten to conform to the general
TestCollection patterns. A bulk test has been included for
sublists and sub-sublists.
Removed the deprecated method from TestCollection, as no one uses
it anymore.
Modified TestCursorableLinkedList so that serialization tests on
sublists and sub-sublists are ignored.
The new tests found 2 minor bugs in CursorableLinkedList. I'm
submitting a patch for it too. Without the bug fix patch, the
new TestList will introduce 2 failures into the build.
-Paul
Re: [PATCH][Collections] TestList
Posted by "Michael A. Smith" <ma...@apache.org>.
On Tue, 18 Jun 2002, Jack, Paul wrote:
> Okay, this shouldn't be as difficult as the previous patches.
> The TestList tests have been rewritten to conform to the general
> TestCollection patterns. A bulk test has been included for
> sublists and sub-sublists.
I'm a bit leery about the manner in which you're testing for fail-fast
behavior, but I committed anyway.
> Removed the deprecated method from TestCollection, as no one uses
> it anymore.
fine... glad to see it gone. :)
> Modified TestCursorableLinkedList so that serialization tests on
> sublists and sub-sublists are ignored.
yeah, that looks like it would be annoying to have to do in all list
test classes. Is there a better way to avoid the serialization tests
for those?
> The new tests found 2 minor bugs in CursorableLinkedList. I'm
> submitting a patch for it too. Without the bug fix patch, the
> new TestList will introduce 2 failures into the build.
I see four, but your patch still fixes them. :)
regards,
michael
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>