[GitHub] [incubator-superset] rusackas commented on issue #9360: Migrate unique Heatmap controls

[GitBox <gi...@apache.org>]

rusackas commented on issue #9360: Migrate unique Heatmap controls
URL: https://github.com/apache/incubator-superset/pull/9360#issuecomment-603447485
 
 
   > @villebro I am proposing each chart maintain their own copy of the control config to keep them independent. There are no value added for histogram and heatmap sharing the same `normalized` field when it is not clear if it indicates the same behavior on both charts.
   
   Following up here to mirror a Slack discussion... we can keep this pass to pulling out the singletons, but in another pass, we can start copying multiple-use controls into individual plugins, and removing the overrides that plugins are layering on. I propose continuing our per-plugin singleton-removal pass, and then doing a per-control pass next to start chewing away at the remaining list. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org