[GitHub] [hadoop] snvijaya commented on a change in pull request #1790: [HADOOP-16818] ABFS: Combine append+flush calls for blockblob & appendblob

[GitBox <gi...@apache.org>]

snvijaya commented on a change in pull request #1790: [HADOOP-16818] ABFS: Combine append+flush calls for blockblob & appendblob
URL: https://github.com/apache/hadoop/pull/1790#discussion_r388085796
 
 

 ##########
 File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemE2E.java
 ##########
 @@ -209,9 +209,10 @@ public void testFlushWithFileNotFoundException() throws Exception {
 
     fs.delete(testFilePath, true);
     assertFalse(fs.exists(testFilePath));
+    AbfsConfiguration configuration = this.getConfiguration();
 
-    intercept(FileNotFoundException.class,
-            () -> stream.close());
+    //With the new code, it would not trigger a call to the backend
 
 Review comment:
   Could you please point me to the check in close() call that prevents server call ?
   
   Also have the tests been run on these different configurations:
   1. With appenblob feature enabled
   - With and Without Namespace enabled account : fs.azure.enable.appendwithflush true and false
   2. With appenblob feature disabled
   - With and Without Namespace enabled account : fs.azure.enable.appendwithflush true and false
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org