You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/25 01:29:25 UTC

[GitHub] [incubator-pinot] pradeepgv42 opened a new pull request #5755: Pradeep/s3 credential chain fix

pradeepgv42 opened a new pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755


   ## Description
   For S3PinotFs
   
   Use DefaultCredentialProvider which chains common ways to provider credentials
   For example: Credentials provider file and Instance profile based credentials were missing. 
   (https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/credentials/DefaultCredentialsProvider.html)
   
   Fixig a Bug in isDirectory S3PinotFs HeadObjectRequst key contained a "/" as prefix which is causing it to fail.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] kishoreg merged pull request #5755: Pradeep/s3 credential chain fix

Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] KKcorps commented on pull request #5755: Pradeep/s3 credential chain fix

Posted by GitBox <gi...@apache.org>.
KKcorps commented on pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755#issuecomment-663813201


   Also, can you mentioned what's the bug in S3Mock?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] pradeepgv42 commented on pull request #5755: Pradeep/s3 credential chain fix

Posted by GitBox <gi...@apache.org>.
pradeepgv42 commented on pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755#issuecomment-663818187


   So, initially I just fixed headObjectRequest (https://github.com/apache/incubator-pinot/pull/5755/commits/e359dc109a786e55637ddc8dc8fc644e7d87760f) 
   
   `testDeleteFile` was failing because HeadObjectRequest from S3Mock was returning back a response 
   even for non existing key `a-delete.txt/`. Does that make sense? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] KKcorps commented on pull request #5755: Pradeep/s3 credential chain fix

Posted by GitBox <gi...@apache.org>.
KKcorps commented on pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755#issuecomment-663813055


   LGTM! The motivation behind headObjectRequest was to check the folders quickly since it just retrieves the metadata. It obviously fails when there is no folder with the provided name but there is an object which has the folderName as part of the key. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] KKcorps edited a comment on pull request #5755: Pradeep/s3 credential chain fix

Posted by GitBox <gi...@apache.org>.
KKcorps edited a comment on pull request #5755:
URL: https://github.com/apache/incubator-pinot/pull/5755#issuecomment-663813201


   Also, can you mention what's the bug in S3Mock?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org