You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/07 10:06:59 UTC

[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1010: refactor: pages to ts

SkyeYoung opened a new pull request, #1010:
URL: https://github.com/apache/apisix-website/pull/1010

   Fixes: #[Add issue number here]
   
   Changes:
   
   This PR fixes part of  #653.
   
   Screenshots of the change:
   
   <!-- Add screenshots depicting the changes. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan merged pull request #1010: refactor: pages to ts

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #1010:
URL: https://github.com/apache/apisix-website/pull/1010


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1010: refactor: pages to ts

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1010:
URL: https://github.com/apache/apisix-website/pull/1010#discussion_r845935573


##########
website/src/pages/help.tsx:
##########
@@ -65,30 +63,27 @@ function Help(props) {
           </div>
           <p>Ask questions about the documentation and project</p>
           <div className="buttons">
-            <a href="https://github.com/apache/apisix/issues" target="_blank">
+            <a href="https://github.com/apache/apisix/issues" target="_blank" rel="noreferrer">
               GitHub
               <ChevronRight />
             </a>
             <a
               href="https://apisix.apache.org/docs/general/join"
               target="_blank"
+              rel="noreferrer"
             >
               Slack
               <ChevronRight />
             </a>
-            <a href="https://twitter.com/ApacheAPISIX" target="_blank">
+            <a href="https://twitter.com/ApacheAPISIX" target="_blank" rel="noreferrer">

Review Comment:
   According to https://www.reliablesoft.net/noreferrer-noopener/#noreferrer, I'm not sure if we need to use `noreferrer`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #1010: refactor: pages to ts

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #1010:
URL: https://github.com/apache/apisix-website/pull/1010#issuecomment-1091480856

   ### <span aria-hidden="true">👷</span> Deploy Preview for *apache-apisix* processing.
   
   
   |  Name | Link |
   |---------------------------------|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 95495ad111a767ac225a9576bf7cb8ca6a1cd6e8 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/624eb7c3be01c60009bac6bb |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org