You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/05/19 22:59:38 UTC
[GitHub] [iceberg] aokolnychyi opened a new issue, #7663: Rename table property for enabling Parquet dictionary encoding
aokolnychyi opened a new issue, #7663:
URL: https://github.com/apache/iceberg/issues/7663
### Feature Request / Improvement
See [here](https://github.com/apache/iceberg/pull/7301/files#r1199411330).
### Query engine
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on issue #7663: Rename table property for enabling Parquet dictionary encoding
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on issue #7663:
URL: https://github.com/apache/iceberg/issues/7663#issuecomment-1555360092
Commented on https://github.com/apache/iceberg/pull/7301#issuecomment-1555346282 , we may want to see if we even want a table property in the first place, curious to know others thoughts @singhpk234 @Fokko @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on issue #7663: Rename table property for enabling Parquet dictionary encoding
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on issue #7663:
URL: https://github.com/apache/iceberg/issues/7663#issuecomment-1555378922
I agree with @amogh-jahagirdar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed issue #7663: Rename table property for enabling Parquet dictionary encoding
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue closed issue #7663: Rename table property for enabling Parquet dictionary encoding
URL: https://github.com/apache/iceberg/issues/7663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #7663: Rename table property for enabling Parquet dictionary encoding
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on issue #7663:
URL: https://github.com/apache/iceberg/issues/7663#issuecomment-1556308968
I'm +1 for removing this property entirely. It is only used for testing and we've never had a request for it in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on issue #7663: Rename table property for enabling Parquet dictionary encoding
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #7663:
URL: https://github.com/apache/iceberg/issues/7663#issuecomment-1555872635
> Dictionary encoding is useful for low cardinality columns, so the space difference between the two is negligible, with the tradeoff being deterministic lookups vs False positives from the bloom filter.
If it is low cardinality, the likelihood of having false positives is also low (assuming a fixed size bit for the bloom filter). I'm not sure if the dictionary is used for skipping data for example, but I don't think that should influence or impact this decision. Because if that's not the case, then we should fix that :)
I'm not super strong on this, but in the end, I think less configuration is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org