You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/03 21:41:25 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #7896: ARROW-9609: [C++][Dataset] CsvFileFormat reads all virtual columns as null

nealrichardson commented on a change in pull request #7896:
URL: https://github.com/apache/arrow/pull/7896#discussion_r464676677



##########
File path: cpp/src/arrow/dataset/file_csv.cc
##########
@@ -39,49 +41,92 @@ namespace dataset {
 using internal::checked_cast;
 using internal::checked_pointer_cast;
 
+Result<std::unordered_set<std::string>> GetColumnNames(

Review comment:
       Would it make sense/be possible to move this somewhere more generally available for CSV reading? @romainfrancois encountered a similar need in https://github.com/apache/arrow/pull/7807#issuecomment-662045381




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org