[GitHub] [kyuubi] pan3793 commented on pull request #4915: Adapt database not exist error message change for Spark 3.4

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on PR #4915:
URL: https://github.com/apache/kyuubi/pull/4915#issuecomment-1571294898

   > shall we address L66 as well?
   
   Seems not necessary, because we catch can rethrow the exception
   
   ```
     override def setCurrentCatalog(spark: SparkSession, catalog: String): Unit = {
       // SPARK-36841(3.3.0) Ensure setCurrentCatalog method catalog must exist
       if (spark.sessionState.catalogManager.isCatalogRegistered(catalog)) {
         spark.sessionState.catalogManager.setCurrentCatalog(catalog)
       } else {
         throw new IllegalArgumentException(s"Cannot find catalog plugin class for catalog '$catalog'")
       }
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org