You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/01/10 01:16:01 UTC
[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5653
Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit
......................................................................
IMPALA-4749: hit DCHECK in sorter with scratch limit
The bug is that on one error path where we don't goto
the cleanup block that all the other error paths use.
Testing:
The test fix for IMPALA-4745 triggers the bug.
Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
---
M be/src/runtime/sorter.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/5653/1
--
To view, visit http://gerrit.cloudera.org:8080/5653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/159/
--
To view, visit http://gerrit.cloudera.org:8080/5653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4749: hit DCHECK in sorter with scratch limit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4749: hit DCHECK in sorter with scratch limit
......................................................................
IMPALA-4749: hit DCHECK in sorter with scratch limit
The bug is that on one error path where we don't goto
the cleanup block that all the other error paths use.
Testing:
The test fix for IMPALA-4745 triggers the bug.
Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Reviewed-on: http://gerrit.cloudera.org:8080/5653
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/runtime/sorter.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id85b96826f13f74c7c5474b0b50e12229e9d8b4f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins