[GitHub] [spark] gengliangwang commented on a change in pull request #34833: [SPARK-37533][SQL] try_element_at should throw an error on 0 array index

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #34833:
URL: https://github.com/apache/spark/pull/34833#discussion_r764639729



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -1996,9 +1996,10 @@ case class ArrayPosition(left: Expression, right: Expression)
  */
 @ExpressionDescription(
   usage = """
-    _FUNC_(array, index) - Returns element of array at given (1-based) index. If index < 0,

Review comment:
       Let's mention that 0 index will throw an error in the function description.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org