You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/16 14:28:03 UTC
[GitHub] [beam] Abacn opened a new pull request, #23274: Fix Kafka performance test expected hash
Abacn opened a new pull request, #23274:
URL: https://github.com/apache/beam/pull/23274
Finally Fixes #22944
Hash were obtained from #23270 with pipeline bypassing kafka (generate records directly and calculate hash)
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249510428
Java_Kafka_IO_Direct and Java KafkaIO Performance Test used different key size in sourceOptions that's why hash was not the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249541076
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23274: Fix Kafka performance test sourceOption to match expected hash
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249553422
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249552486
R: @johnjcasey PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249515928
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @apilloud for label java.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249550506
> It looks like this causes the batch tests to fail though
Found the precommit and performance test used different sourceOption. Change the performance test to be the same as precommit should fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #23274: Fix Kafka performance test sourceOption to match expected hash
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #23274:
URL: https://github.com/apache/beam/pull/23274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249435935
Run Java KafkaIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23274: Fix Kafka performance test sourceOption to match expected hash
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249561672
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249541708
It looks like this causes the batch tests to fail though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23274: Fix Kafka performance test expected hash
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23274:
URL: https://github.com/apache/beam/pull/23274#issuecomment-1249540921
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org