You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/04/14 19:29:32 UTC
[GitHub] [celix] abroekhuis opened a new issue #196: Support multiple build
configurations
abroekhuis opened a new issue #196: Support multiple build configurations
URL: https://github.com/apache/celix/issues/196
Currently the CMake files don't do anything specific for different build configs. To be able to have release and debug libraries next to each other the following is needed:
* Add postfix: "d" // this somewhat seems to be the standard
* Check if al custom functions work
@pnoltes What else could go wrong? First test seems to be ok for most things (tests and bundle files as well as the executabled).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] abroekhuis commented on issue #196: Support multiple build
configurations
Posted by GitBox <gi...@apache.org>.
abroekhuis commented on issue #196: Support multiple build configurations
URL: https://github.com/apache/celix/issues/196#issuecomment-613970392
This raises another question, currently a debug build works, all libraries are postfixed with "d", and manifest files and configurations are correct.
But, resulting bundles don't have a debug prefix. So that also means that the CelixTargets.cmake works as it is.
However, I can also think of situations where we want to be able to release bundles for debug, release, etc.
I thinks this adds the following to the list:
* Add postfix to bundle names
This then also requires an update to the CelixTargets, to actually have a debug and release version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes commented on issue #196: Support multiple build
configurations
Posted by GitBox <gi...@apache.org>.
pnoltes commented on issue #196: Support multiple build configurations
URL: https://github.com/apache/celix/issues/196#issuecomment-613872314
We have to do some work for the exported bundles target.
The following part:
```CMake
#export targets
install(EXPORT celix NAMESPACE Celix:: DESTINATION share/celix/cmake FILE Targets.cmake COMPONENT cmake)
install_celix_targets(celix NAMESPACE Celix:: DESTINATION share/celix/cmake FILE CelixTargets.cmake COMPONENT cmake)
```
Generates a Targets.cmake and (if I am correct) a Targets-<CMAKE_BUILD_TYPE>.cmake. So this supports multiple build configurations.
The celix command now only generated a CelixTargets.cmake, no CelixTargets-<CMAKE_BUILD_TYPE>.cmake.
This should also be addressed -> mimic behaviour of install(EXPORT ...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] abroekhuis commented on issue #196: Support multiple build
configurations
Posted by GitBox <gi...@apache.org>.
abroekhuis commented on issue #196: Support multiple build configurations
URL: https://github.com/apache/celix/issues/196#issuecomment-613971200
Also, doing some tests, when doing an install with Debug, and next with Release, libraries are kept, resulting in release and debug libs next to each other.
However.. the install(EXPORT ..) stuff is not kept. For Debug a Targets and Targets-Debug is installed. Running the Release install removed those 2 files, and places back a Targets and Targets-Release.
Not sure yet how to prevent this. IMO we want both files (or multiple, depending on build types) next to each other. The Targets file itself is the same for different build types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [celix] pnoltes commented on issue #196: Support multiple build
configurations
Posted by GitBox <gi...@apache.org>.
pnoltes commented on issue #196: Support multiple build configurations
URL: https://github.com/apache/celix/issues/196#issuecomment-613974855
> Also, doing some tests, when doing an install with Debug, and next with Release, libraries are kept, resulting in release and debug libs next to each other.
> However.. the install(EXPORT ..) stuff is not kept. For Debug a Targets and Targets-Debug is installed. Running the Release install removed those 2 files, and places back a Targets and Targets-Release.
> Not sure yet how to prevent this. IMO we want both files (or multiple, depending on build types) next to each other. The Targets file itself is the same for different build types.
I also expected that both files were kept.. strange.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services