You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/12 02:45:04 UTC

[GitHub] [spark] hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform

hddong commented on issue #24048: [MINOR][Core] Use variable instead of function to keep the format uniform
URL: https://github.com/apache/spark/pull/24048#issuecomment-471829959
 
 
   > As I see this is really a minor thing where separate Jira is not needed still the PR title must follow the standard formatting in this case it could be: "[MINOR][Core] Use variable instead of function call to keep the format uniform"
   > 
   > I would also mention this is done in the constructor of the SparkContext and would delete the line "Please review http://spark.apache.org/contributing.html before opening a pull request." from the description and just say "existing unit tests".
   
   Thanks for your guidance, I'll read it again carefully.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org