[GitHub] [skywalking] HackerRookie opened a new issue #3622: Double-counting sample values:create entrySpan and singleSpan

[GitBox <gi...@apache.org>]

HackerRookie opened a new issue #3622: Double-counting sample values:create entrySpan and singleSpan
URL: https://github.com/apache/skywalking/issues/3622
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [*] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   Double-counting sample values:create entrySpan and singleSpan
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, component version.
   public AbstractTracerContext createTraceContext(String operationName, boolean forceSampling) {
           AbstractTracerContext context;
           int suffixIdx = operationName.lastIndexOf(".");
           if (suffixIdx > -1 && Config.Agent.IGNORE_SUFFIX.contains(operationName.substring(suffixIdx))) {
               context = new IgnoredTracerContext();
           } else {
               SamplingService samplingService = ServiceManager.INSTANCE.findService(SamplingService.class);
               if (forceSampling || samplingService.trySampling()) {
                   context = new TracingContext();
               } else {
                   context = new IgnoredTracerContext();
               }
           }
   
           return context;
       }
   
   finish()
   
    if (!segment.hasRef() && segment.isSingleSpanSegment()) {
                       if (!samplingService.trySampling()) {
                           finishedSegment.setIgnore(true);
                       }
                   }
   
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services