[GitHub] [arrow-datafusion] 2010YOUY01 commented on a diff in pull request #6527: [built-in function] add greatest() and least() SQL functions

["2010YOUY01 (via GitHub)" <gi...@apache.org>]

2010YOUY01 commented on code in PR #6527:
URL: https://github.com/apache/arrow-datafusion/pull/6527#discussion_r1215835989


##########
datafusion/expr/src/function.rs:
##########
@@ -376,6 +381,9 @@ pub fn signature(fun: &BuiltinScalarFunction) -> Signature {
         BuiltinScalarFunction::Chr | BuiltinScalarFunction::ToHex => {
             Signature::uniform(1, vec![DataType::Int64], fun.volatility())
         }
+        BuiltinScalarFunction::Greatest | BuiltinScalarFunction::Least => {
+            Signature::variadic_equal(fun.volatility())

Review Comment:
   Should be `Signature::variadic_equal(SUPPORTED_COMPARISON_TYPES, fun.volatility())`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org