You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/01 22:45:15 UTC
[GitHub] [arrow] wesm opened a new pull request #7321: ARROW-8985: [Format][DONOTMERGE] RFC Proposed Decimal::byteWidth field for forward compatibility
wesm opened a new pull request #7321:
URL: https://github.com/apache/arrow/pull/7321
See mailing list discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7321: ARROW-8985: [Format] Add Decimal::bitWidth field with default value of 128 for forward compatibility
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7321:
URL: https://github.com/apache/arrow/pull/7321#issuecomment-650575218
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7321: ARROW-8985: [Format][DONOTMERGE] RFC Proposed Decimal::byteWidth field for forward compatibility
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7321:
URL: https://github.com/apache/arrow/pull/7321#discussion_r443958283
##########
File path: format/Schema.fbs
##########
@@ -134,11 +134,20 @@ table FixedSizeBinary {
table Bool {
}
+/// Exact decimal value represented as an integer value in two's
+/// complement. Currently only 128-bit (16-byte) integers are used but this may
Review comment:
endianness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7321: ARROW-8985: [Format][DONOTMERGE] RFC Proposed Decimal::byteWidth field for forward compatibility
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7321:
URL: https://github.com/apache/arrow/pull/7321#issuecomment-637164899
https://issues.apache.org/jira/browse/ARROW-8985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7321: ARROW-8985: [Format] Add Decimal::bitWidth field with default value of 128 for forward compatibility
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7321:
URL: https://github.com/apache/arrow/pull/7321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on a change in pull request #7321: ARROW-8985: [Format][DONOTMERGE] RFC Proposed Decimal::byteWidth field for forward compatibility
Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7321:
URL: https://github.com/apache/arrow/pull/7321#discussion_r444249804
##########
File path: format/Schema.fbs
##########
@@ -134,11 +134,20 @@ table FixedSizeBinary {
table Bool {
}
+/// Exact decimal value represented as an integer value in two's
+/// complement. Currently only 128-bit (16-byte) integers are used but this may
Review comment:
This should use the endianness indicated by the schema, I believe (like the other data types)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org