[GitHub] [incubator-druid] himanshug commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

[GitBox <gi...@apache.org>]

himanshug commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster
URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-543354123
 
 
   > Motivation ... allowing the creation of a check that would make sure all runtime props are set correctly and that all nodes are reachable
   
   > The proxy could only forward to Druid nodes themselves so it is not open to everything.
   
   to achieve above you would have to check if "node-host,port" received in request is indeed a druid process  which requires that particular process successfully registered itself in zookeeper and discovered by router.  so the two requirements above depend on each other.
    
   I would agree with @jnaous on the async philosophy in general for this kind of use case.
   
   https://github.com/apache/incubator-druid/pull/8672#issuecomment-542376613 applies too :)
   
   OTOH I think you want the proxy because it is doable quickly and would give you a lot of freedom as to try things in web console, gather feed back, iterate more and when we know the concrete useful use cases, they could be implemented in router for efficiency (and/or proactive checkups ) . If intention is to allow quick experimentation really then I think it is ok to setup the proxy mechanism at router but with a configuration that enables such proxy and set to `false` by default. Only ask would be that web console should continue to work for all other things even if generic proxy is disabled at router.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org