You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by cammckenzie <gi...@git.apache.org> on 2015/01/13 06:45:40 UTC
[GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
GitHub user cammckenzie opened a pull request:
https://github.com/apache/curator/pull/62
CURATOR-111 - Modified the authorization handling so that the underlying
auth data is stored in a single list. Modified tests to have both a single
auth and multiple auth case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-111
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 58328915a6e005bc4171bb866cb2eba4762c3718
Author: Cameron McKenzie <ca...@unico.com.au>
Date: 2015-01-13T05:42:59Z
CURATOR-111 - Modified the authorization handling so that the underlying
auth data is stored in a single list. Modified tests to have both a single
auth and multiple auth case.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/62#discussion_r22857953
--- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java ---
@@ -380,16 +383,6 @@ public String getNamespace()
return namespace;
}
- public String getAuthScheme()
--- End diff --
I think these methods should stay and be marked as deprecated so this is not a breaking change. The old methods can either return return the first auth or throw an error if there is more than 1 auth.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-111 - Modified the authorization han...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/62#discussion_r22858035
--- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java ---
@@ -163,8 +166,8 @@ public CuratorTempFramework buildTemp(long inactiveThreshold, TimeUnit unit)
*/
public Builder authorization(String scheme, byte[] auth)
{
- this.authScheme = scheme;
- this.authValue = (auth != null) ? Arrays.copyOf(auth, auth.length) : null;
+ this.authInfos = Lists.newArrayList();
--- End diff --
This should call authorization(List<AuthInfo> authInfos). E.g.
```
return authorization(Lists.newArrayList(new AuthInfo(scheme, (auth != null) ? Arrays.copyOf(auth, auth.length) : null)));
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---