You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/11 13:46:16 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1026: fix: login bg displayed imcompletely

liuxiran opened a new pull request #1026:
URL: https://github.com/apache/apisix-dashboard/pull/1026


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   
   ___
   ### Bugfix
   - Description
   current login page’s background(update dashboard to master) displayed imcompletely:
   
   ![2020-12-11 21-41-56屏幕截图](https://user-images.githubusercontent.com/2561857/101910580-17144800-3bfa-11eb-8848-7cd1c7f1a0ff.png)
   
   
   - How to fix?
   
   updated less files.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1026: fix: login bg displayed imcompletely

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1026:
URL: https://github.com/apache/apisix-dashboard/pull/1026#issuecomment-744173479


   > This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran
   > ![image](https://user-images.githubusercontent.com/31329157/102037017-20bacd00-3dff-11eb-8bc4-02478644ad16.png)
   
   
   After I rm node_modules and reinstall node dependences, this page looks ok now.
   
   after compared the difference between the two, I found that:
   currently the login component is rendering undering `pro-basicLayout`
   ![mmexport1607922392820](https://user-images.githubusercontent.com/2561857/102042738-929a1300-3e0d-11eb-851f-7ada93ac01a1.jpg)
   
   while the page in the issue is rendering itself
   
   ![mmexport1607922364748](https://user-images.githubusercontent.com/2561857/102042888-f02e5f80-3e0d-11eb-9b50-811294b9afc1.jpg)
   
   It may be caused by the package version, and I could not reproduce it now. 
   
   close this pr when it can be reproduced, I'll reopen it again.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1026: fix: login bg displayed imcompletely

Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1026:
URL: https://github.com/apache/apisix-dashboard/pull/1026#issuecomment-744142188


   This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran 
   ![image](https://user-images.githubusercontent.com/31329157/102037017-20bacd00-3dff-11eb-8bc4-02478644ad16.png)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran closed pull request #1026: fix: login bg displayed imcompletely

Posted by GitBox <gi...@apache.org>.
liuxiran closed pull request #1026:
URL: https://github.com/apache/apisix-dashboard/pull/1026


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org