You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/23 06:33:20 UTC
[GitHub] [kafka] showuon opened a new pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
showuon opened a new pull request #11115:
URL: https://github.com/apache/kafka/pull/11115
Replace the unsupported describe topic via zk with describe users to fix the system tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#issuecomment-885431546
@ijuma @rondagostino , please help take a look. Thank you.
Verified in my local env that the test verification can be passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11115:
URL: https://github.com/apache/kafka/pull/11115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#issuecomment-885906003
No worries, I ran a few variations and they look good. Also cherry-picked this to 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#issuecomment-885611405
@showuon `upgrade_test` passes with these changes, I assume?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#issuecomment-885431546
@ijuma @rondagostino , please help take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#discussion_r675525994
##########
File path: tests/kafkatest/services/zookeeper.py
##########
@@ -220,16 +220,15 @@ def create(self, path, chroot=None, value=""):
output = self.nodes[0].account.ssh_output(cmd)
self.logger.debug(output)
- def describe(self, topic):
+ def describeUsers(self):
Review comment:
replace the original `describe` topic method with `describeUsers` since describe topic via zk is not supported anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11115:
URL: https://github.com/apache/kafka/pull/11115#issuecomment-885649500
@ijuma , I have to admit that I cannot complete the `upgrade_test` test successfully in my local environment, and I think that's because my machine is not power enough to complete it. So sometimes I get "Kafka server didn't finish startup in 60 seconds", and sometimes I get "Replicas did not rejoin the ISR in a reasonable amount of time".
I checked the system tests results that run by @rondagostino in this PR: https://github.com/apache/kafka/pull/10982 before the `configCommand` change merged, all `upgrade_test` are passed. So, I assume the only issue we have now for `upgrade_test` is `zk.describe()`. At least, I can confirmed that the `zk.describe()` failure is fixed now.
Sorry, and thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org