[jira] [Commented] (GEODE-852) (Re)move pulseversion.properties file

["Dan Smith (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117675#comment-15117675 ] 

Dan Smith commented on GEODE-852:
---------------------------------

GEODE-854 is fixed - we're not longer putting a pulseversion.properties in the source directory. However, we should still only create 1 properties file and use it in both places.

> (Re)move pulseversion.properties file
> -------------------------------------
>
>                 Key: GEODE-852
>                 URL: https://issues.apache.org/jira/browse/GEODE-852
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Anthony Baker
>
> Currently the pulse build is creating the file gemfire-pulse/src/main/resources/pulseversion.properties.  I have a few observations:
> 1) We should always create generated files in the generated-* directory.  For example:  gemfire-core/build/generated-resources/main/com/gemstone/gemfire/internal/GemFireVersion.properties
> This means we can remove the exclusion from rat.gradle.
> 2) We already create GemFireVersion.properties.  Can pulse use that file instead?  If not, we should at least merge the common code to create these files (see gemfire-core/build.gradle).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)