You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2015/05/01 00:04:05 UTC

[GitHub] incubator-streams pull request: resolves STREAMS-313 #313

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/216

    resolves STREAMS-313 #313

    neo4j runtime dependencies are scope:provided and optional
    using the existing Http-based writer does not require neo4j libraries
    using the Binary writer does, but it's up to the implementing stream to import it

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-streams STREAMS-313

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit cb1aaea3e127cf4b9b72dd110883765450c74976
Author: Steve Blackmon (@steveblackmon) <sb...@apache.org>
Date:   2015-04-30T22:03:05Z

    resolves STREAMS-313 #313
    neo4j runtime dependencies are scope:provided and optional
    using the existing Http-based writer does not require neo4j libraries
    using the Binary writer does, but it's up to the implementing stream to import it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-313 #313

Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:

    https://github.com/apache/incubator-streams/pull/216#issuecomment-112557421
  
    I believe the dependency issue is resolved.
    
    I will lazy consensus merge this in 48 hours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-313 #313

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-streams/pull/216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-streams pull request: resolves STREAMS-313 #313

Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/216#discussion_r29957068
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -31,13 +33,15 @@
     import org.apache.streams.config.ComponentConfigurator;
     import org.apache.streams.config.StreamsConfigurator;
     import org.apache.streams.core.StreamsDatum;
    -import org.apache.streams.graph.neo4j.CypherGraphHelper;
    --- End diff --
    
    unfortunately, these imports create the problem.  FSF's position is that even dynamically linked binaries are considered combined works and are therefore subject to GPL. 
    
    There is an active effort by Neo4J to come up with a viable solution.  See the following thread:
    
    http://s.apache.org/9SS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---