You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2012/05/31 10:32:24 UTC
[jira] [Created] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Julian Reschke created JCR-3325:
-----------------------------------
Summary: check-release script fails to compute hashes on Cygwin (conf'd to text mode)
Key: JCR-3325
URL: https://issues.apache.org/jira/browse/JCR-3325
Project: Jackrabbit Content Repository
Issue Type: Bug
Reporter: Julian Reschke
Priority: Minor
In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
For gpg, I haven't figured out yet how to fix it.
(Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-3325:
-----------------------------------
Assignee: Julian Reschke
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287274#comment-13287274 ]
Alex Parvulescu commented on JCR-3325:
--------------------------------------
the patch looks good, +1.
Do you have any more info about the gpg error? Any message/warning?
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288612#comment-13288612 ]
Julian Reschke commented on JCR-3325:
-------------------------------------
Roy; you are right, but I believe the change doesn't break anything that wasn't already broken before (note $hash is a filename as well)
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3325:
--------------------------------
Attachment: JCR-3325.patch
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287319#comment-13287319 ]
Julian Reschke commented on JCR-3325:
-------------------------------------
gpg: the only visible problem is that it's computing an incorrect hash.
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Roy T. Fielding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288031#comment-13288031 ]
Roy T. Fielding commented on JCR-3325:
--------------------------------------
If the filename can contain spaces, it needs to be quoted. IIRC,
B="`openssl $hash \"$f\" 2>/dev/null | sed 's/.*= *//' `"
should work, but I haven't tested.
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3325:
---------------------------------
Fix Version/s: 2.5.1
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 2.5.1
>
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3325) check-release script fails to compute
hashes on Cygwin (conf'd to text mode)
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved JCR-3325.
---------------------------------
Resolution: Fixed
I have worked around the openssl problem by using a different command line syntax (argument instead of stdin redirection).
There doesn't seem to be a simple fix for gpg, which appears to use text mode even when opening named files; it appears this is a problem of the Cygwin port, as the source seems to conditionally setmode() the file to binary.
I may open bugs against the ports; in which case I'll update this issue with links.
> check-release script fails to compute hashes on Cygwin (conf'd to text mode)
> ----------------------------------------------------------------------------
>
> Key: JCR-3325
> URL: https://issues.apache.org/jira/browse/JCR-3325
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3325.patch
>
>
> In check-release.sh, the invocations for openssl and qgp do not work with Cygwin (text mode), because both programs apparently fail to read binary from stdin (that's a bug in both programs).
> For openssl, the simple work around is to pass the filename as parameter instead of redirecting stdin.
> For gpg, I haven't figured out yet how to fix it.
> (Fixing the openssl invocation at least makes 2 out of 3 hashes match)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira