You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/03/19 11:41:14 UTC
[PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
lhotari opened a new pull request, #858:
URL: https://github.com/apache/pulsar-site/pull/858
### Motivation
There seems to be a hardcoded ApacheID -> GitHub ID mappings: https://github.com/apache/pulsar-site/blob/d7e1e218f025fa8ad3f3a88c03eb9ec3cafe1a81/src/components/pages/CommunityPage/CommunityPage.tsx#L29-L33
This doesn't make sense since the GitHub usernames are available from ASF.
In ASF, it's possible to have multiple GitHub user ids so that's the reason why it's an array.
### Modification
- add script for updating information from ASF Whimsy's pulsar.json data file
### ✅ Contribution Checklist
<!--
Feel free to remove the checklist if it does not apply to your PR
-->
- [ ] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/)
- [ ] I updated the [versioned docs](https://pulsar.apache.org/contribute/document-contribution/#update-versioned-docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530277540
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
Agree. In this case, we should render a regular div instead of a link that refers to the GitHub profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#issuecomment-2007048241
btw. All ASF committers / PMC members would have to manually enter their GitHub Id at https://whimsy.apache.org/roster/committer/__self__ and then clicking the "GitHub username(s) (user-provided)" to enter the GitHub id. After that, the synchronization would have to be done to `data/team.js` with `scripts/sync-team-js.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530295588
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
I just tried, but it looks broken:
<img width="529" alt="Screenshot 2024-03-19 at 4 44 15 PM" src="https://github.com/apache/pulsar-site/assets/9302460/dce8d71b-f028-4c57-9128-58c4aa87f6b2">
At the same time after I clicked the "Link GitHub username(s) to ASF id":
<img width="687" alt="Screenshot 2024-03-19 at 4 45 26 PM" src="https://github.com/apache/pulsar-site/assets/9302460/c051b4c2-62dd-4a3d-b7d0-e62976f2fa82">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530305784
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
Nope, don't use the "Link GitHub username to ASF id" link... It's the "GitHub username(s) (user-provided)" label as described in https://github.com/apache/pulsar-site/pull/858/files#r1530302378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530262302
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -45,6 +45,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername && member.githubUsername.length > 0 ? member.githubUsername[0] : member.apacheId;
+ const href = member.githubUsername && member.githubUsername.length > 0 ? ('https://github.com/' + githubUsername) : "#";
+ const target = member.githubUsername && member.githubUsername.length > 0 ? "_blank" : "_self";
Review Comment:
```suggestion
const target = githubUsername ? "_blank" : "_self";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530310501
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
> The UI is very confusing. You should be able to double click on the "GitHub username(s) (user-provided)" label to enter your GitHub Id.
It worked
No way to figure out it by myself :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530261712
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -45,6 +45,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername && member.githubUsername.length > 0 ? member.githubUsername[0] : member.apacheId;
+ const href = member.githubUsername && member.githubUsername.length > 0 ? ('https://github.com/' + githubUsername) : "#";
Review Comment:
```suggestion
const href = githubUsername ? ('https://github.com/' + githubUsername) : "#";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530275786
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
Actually, the default isn't great, I'd rather have everyone opt-in by adding their GitHub id explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#issuecomment-2006967152
@lhotari will you update the [/CommunityPage.tsx](https://github.com/apache/pulsar-site/blob/d7e1e218f025fa8ad3f3a88c03eb9ec3cafe1a81/src/components/pages/CommunityPage/CommunityPage.tsx#L29-L33) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530271037
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -24,6 +24,24 @@ export default function CommunityPage(): JSX.Element {
<Button title={isShowMoreCmtrs ? 'Show less' : 'Show more'} variant="transparentWhite" onClick={() => setIsShowMoreCmtrs(!isShowMoreCmtrs)}/>
);
+ function shuffleArray(array) {
Review Comment:
There is `lodash` function for that: https://lodash.com/docs/4.17.15#shuffle
But I do not insist ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530277540
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
Agree. In this case, we should render a regular div instead of a link that refers to the GitHub profile or `#`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#issuecomment-2006965784
I didn't know about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530310501
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
> The UI is very confusing. You should be able to double click on the "GitHub username(s) (user-provided)" label to enter your GitHub Id.
It worked
No way I'd figure it out by myself :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530272558
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
@visortelle btw. this might make a wrong choice for some users. It might be better to not assume that github username matches the apache id.
Every committer should go to [Whimsy](https://whimsy.apache.org/roster/committer/__self__) and add their GitHub id there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530302378
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
The UI is very confusing. You should be able to **double click** on the "GitHub username(s) (user-provided)" **label** to enter your GitHub Id.
<img width="476" alt="image" src="https://github.com/apache/pulsar-site/assets/66864/6303b170-977e-40cc-be91-89a2872b4d92">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530303723
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
Although no, I changed my mind)
Then spend time recovering
<img width="453" alt="Screenshot 2024-03-19 at 4 49 26 PM" src="https://github.com/apache/pulsar-site/assets/9302460/e2cab8b0-afe9-4bfa-abab-9c5746ac4494">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530312600
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
Looks fine now, I updated team.js.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle merged PR #858:
URL: https://github.com/apache/pulsar-site/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530260375
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -45,6 +45,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername && member.githubUsername.length > 0 ? member.githubUsername[0] : member.apacheId;
Review Comment:
```suggestion
const githubUsername = member.githubUsername?.[0] || member.apacheId;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530275072
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
I guess the default might be fine, but we should send emails to the ones that haven't added their GitHub ID in Whimsy if they want to have their GitHub link shown on the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530300388
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -64,7 +64,10 @@ export default function CommunityPage(): JSX.Element {
});
function MemberCard({ member, index }) {
- const githubUsername = member.githubUsername?.[0] || member.apacheId;
+ // require the member to have "GitHub username(s) (user-provided)" field information in Whimsy
+ // the user can go to Whimsy url https://whimsy.apache.org/roster/committer/__self__ to update the information
Review Comment:
<img width="423" alt="Screenshot 2024-03-19 at 4 48 02 PM" src="https://github.com/apache/pulsar-site/assets/9302460/33ed49ec-4fed-4ecd-a05a-dc0e0ceb2785">
Will try to unlink and link again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530277540
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
> this might make a wrong choice for some users. It might be better to not assume that github username matches the apache id.
Agree. In this case, we should render a regular div instead of a link that refers to the GitHub profile or `#`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530292424
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -24,6 +24,24 @@ export default function CommunityPage(): JSX.Element {
<Button title={isShowMoreCmtrs ? 'Show less' : 'Show more'} variant="transparentWhite" onClick={() => setIsShowMoreCmtrs(!isShowMoreCmtrs)}/>
);
+ function shuffleArray(array) {
Review Comment:
makes sense, updated. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GitHub user ids for committers and PMC members to team.js [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #858:
URL: https://github.com/apache/pulsar-site/pull/858#discussion_r1530287280
##########
src/components/pages/CommunityPage/CommunityPage.tsx:
##########
@@ -53,6 +63,27 @@ export default function CommunityPage(): JSX.Element {
teamCtrsSets[CountTheSets].push(element);
});
+ function MemberCard({ member, index }) {
+ const githubUsername = member.githubUsername?.[0] || member.apacheId;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org