[GitHub] [spark] maropu commented on a change in pull request #30973: [SPARK-33934][SQL] Support user defined script command wrapper and handle cmd arg like hive

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30973:
URL: https://github.com/apache/spark/pull/30973#discussion_r551081871



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##########
@@ -69,9 +75,19 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
     }
   }
 
-  protected def initProc: (OutputStream, Process, InputStream, CircularBuffer) = {
-    val cmd = List("/bin/bash", "-c", script)

Review comment:
       > Does hive support such configuration too? It doesn't look particularly necessary to me.
   >> Yea, Hive support such configuration. wait for other committer's review comment too?
   >> gentle ping @cloud-fan @maropu
   
   The @HyukjinKwon idea looks better and I think it's easier for users to use this new feature without any configuration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org