You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/29 16:10:53 UTC
[GitHub] [incubator-eventmesh] horoc opened a new pull request, #1459: [ISSUE #1458] Prevent potential input resource leak
horoc opened a new pull request, #1459:
URL: https://github.com/apache/incubator-eventmesh/pull/1459
Fixes #1458
### Motivation
#1458
### Modifications
#1458
### Documentation
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc commented on pull request #1459: [ISSUE #1458] Prevent potential input resource leak
Posted by GitBox <gi...@apache.org>.
horoc commented on PR #1459:
URL: https://github.com/apache/incubator-eventmesh/pull/1459#issuecomment-1276283494
close and move to another MR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1459: [ISSUE #1458] Prevent potential input resource leak
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1459:
URL: https://github.com/apache/incubator-eventmesh/pull/1459#issuecomment-1262543308
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1459](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ccddd2) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/1bb463700dd0a601b1134c897fbf737b901f9ec4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bb4637) will **decrease** coverage by `0.03%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #1459 +/- ##
============================================
- Coverage 10.37% 10.34% -0.04%
+ Complexity 775 773 -2
============================================
Files 443 443
Lines 26930 26922 -8
Branches 2937 2930 -7
============================================
- Hits 2795 2785 -10
- Misses 23876 23881 +5
+ Partials 259 256 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/eventmesh/common/utils/PropertiesUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9Qcm9wZXJ0aWVzVXRpbHMuamF2YQ==) | `45.94% <0.00%> (-22.06%)` | :arrow_down: |
| [...ntmesh/trace/api/config/ExporterConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL2NvbmZpZy9FeHBvcnRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...connector/knative/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uZmlnL0NvbmZpZ3VyYXRpb25XcmFwcGVyLmphdmE=) | `61.11% <100.00%> (+8.47%)` | :arrow_up: |
| [.../pravega/config/PravegaConnectorConfigWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wcmF2ZWdhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3ByYXZlZ2EvY29uZmlnL1ByYXZlZ2FDb25uZWN0b3JDb25maWdXcmFwcGVyLmphdmE=) | `61.11% <100.00%> (+8.47%)` | :arrow_up: |
| [...h/connector/redis/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `59.09% <100.00%> (+6.91%)` | :arrow_up: |
| [...onnector/rocketmq/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yb2NrZXRtcS9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `61.11% <100.00%> (+8.47%)` | :arrow_up: |
| [...ics/prometheus/config/PrometheusConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvY29uZmlnL1Byb21ldGhldXNDb25maWd1cmF0aW9uLmphdmE=) | `70.83% <100.00%> (+6.83%)` | :arrow_up: |
| [...tmesh/trace/zipkin/config/ZipkinConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2Utemlwa2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2Uvemlwa2luL2NvbmZpZy9aaXBraW5Db25maWd1cmF0aW9uLmphdmE=) | `75.00% <100.00%> (+5.30%)` | :arrow_up: |
| [...ava/org/apache/eventmesh/common/utils/IPUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9JUFV0aWxzLmphdmE=) | `33.33% <0.00%> (-6.49%)` | :arrow_down: |
| [...g/apache/eventmesh/runtime/util/EventMeshUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvRXZlbnRNZXNoVXRpbC5qYXZh) | `75.00% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1459/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc closed pull request #1459: [ISSUE #1458] Prevent potential input resource leak
Posted by GitBox <gi...@apache.org>.
horoc closed pull request #1459: [ISSUE #1458] Prevent potential input resource leak
URL: https://github.com/apache/incubator-eventmesh/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org