You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:26:42 UTC

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #7: [pynq_driver] fix device early return

tmoreau89 commented on a change in pull request #7:
URL: https://github.com/apache/incubator-tvm-vta/pull/7#discussion_r417732849



##########
File path: src/pynq/pynq_driver.cc
##########
@@ -126,6 +127,10 @@ class VTADevice {
     VTAWriteMappedReg(vta_compute_handle_, 0x0, VTA_AUTORESTART);
     VTAWriteMappedReg(vta_store_handle_, 0x0, VTA_AUTORESTART);
 
+    // Allow device to respond

Review comment:
       Could you add more explanation here to make sure that this sleep is well understood for posterity (the summarized comment by @remotego should suffice)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org