You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/11 09:10:26 UTC
Review Request 43475: Speed up
MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43475/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4652
https://issues.apache.org/jira/browse/MESOS-4652
Repository: mesos
Description
-------
Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.
Diffs
-----
src/tests/master_contender_detector_tests.cpp 6375586c31b1fd406529bf299dad6e321b945de8
Diff: https://reviews.apache.org/r/43475/diff/
Testing
-------
Before
```
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (3359 ms)
```
After
```
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (613 ms)
```
Thanks,
haosdent huang
Re: Review Request 43475: Speed up
MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43475/
-----------------------------------------------------------
(Updated April 10, 2016, 10:18 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Update according to @alexr's comments.
Bugs: MESOS-4652
https://issues.apache.org/jira/browse/MESOS-4652
Repository: mesos
Description
-------
Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.
Diffs (updated)
-----
src/tests/master_contender_detector_tests.cpp 1426a173b1f458d67b748016aee311ac008b054a
Diff: https://reviews.apache.org/r/43475/diff/
Testing (updated)
-------
Test repeatly in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster" --verbose --gtest_repeat=200 --gtest_break_on_failure
```
Before
```
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (3359 ms)
```
After
```
[ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (613 ms)
```
Thanks,
haosdent huang