You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/17 12:38:05 UTC
[GitHub] [superset] artemonsh opened a new pull request, #22150: Localization of some charts and elements
artemonsh opened a new pull request, #22150:
URL: https://github.com/apache/superset/pull/22150
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
The localization of some components and especially charts is not complete yet. This PR is the effort to the full localization of Superset.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353504371
# [Codecov](https://codecov.io/gh/apache/superset/pull/22150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22150](https://codecov.io/gh/apache/superset/pull/22150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a9a197) into [master](https://codecov.io/gh/apache/superset/commit/aa0cae9b490405ede604804877304b1df6dd08c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa0cae9) will **decrease** coverage by `1.46%`.
> The diff coverage is `89.47%`.
> :exclamation: Current head 2a9a197 differs from pull request most recent head e6c54db. Consider uploading reports for the commit e6c54db to get more accurate results
```diff
@@ Coverage Diff @@
## master #22150 +/- ##
==========================================
- Coverage 66.90% 65.43% -1.47%
==========================================
Files 1850 1850
Lines 70677 70679 +2
Branches 7749 7749
==========================================
- Hits 47285 46248 -1037
- Misses 21376 22415 +1039
Partials 2016 2016
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `77.97% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `78.02% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `78.15% <100.00%> (-3.09%)` | :arrow_down: |
| sqlite | `76.50% <100.00%> (+<0.01%)` | :arrow_up: |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-chart-controls/src/sections/advancedAnalytics.tsx](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2FkdmFuY2VkQW5hbHl0aWNzLnRzeA==) | `14.28% <ø> (ø)` | |
| [...ui-core/src/chart/components/FallbackComponent.tsx](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvY29tcG9uZW50cy9GYWxsYmFja0NvbXBvbmVudC50c3g=) | `100.00% <ø> (ø)` | |
| [...et-ui-core/src/time-format/formatters/smartDate.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGUudHM=) | `100.00% <ø> (ø)` | |
| [...re/src/time-format/formatters/smartDateDetailed.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGVEZXRhaWxlZC50cw==) | `100.00% <ø> (ø)` | |
| [...ore/src/time-format/formatters/smartDateVerbose.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZm9ybWF0dGVycy9zbWFydERhdGVWZXJib3NlLnRz) | `100.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-calendar/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNhbGVuZGFyL3NyYy9jb250cm9sUGFuZWwudHM=) | `50.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `57.14% <ø> (ø)` | |
| [...ns/legacy-plugin-chart-map-box/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LW1hcC1ib3gvc3JjL2NvbnRyb2xQYW5lbC50cw==) | `30.00% <0.00%> (ø)` | |
| [...legacy-plugin-chart-partition/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvY29udHJvbFBhbmVsLnRzeA==) | `25.00% <ø> (ø)` | |
| [...egacy-plugin-chart-pivot-table/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBpdm90LXRhYmxlL3NyYy9jb250cm9sUGFuZWwudHM=) | `100.00% <ø> (ø)` | |
| ... and [161 more](https://codecov.io/gh/apache/superset/pull/22150/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050033474
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.jsx:
##########
@@ -57,7 +58,7 @@ function setTooltipContent(formData) {
return (
<div className="deckgl-tooltip">
{o.object.name && (
- <TooltipRow label="name: " value={`${o.object.name}`} />
+ <TooltipRow label={t('name: ')} value={`${o.object.name}`} />
Review Comment:
Another example of what I commented on elsewhere. I would think `name` is already translated/used in numerous places, so translating things like this with punctuation/spacing kind of adds some overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #22150: chore: Localization of several charts and elements
URL: https://github.com/apache/superset/pull/22150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050032807
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Scatter/Scatter.jsx:
##########
@@ -36,14 +36,11 @@ function setTooltipContent(formData, verboseMap) {
return (
<div className="deckgl-tooltip">
<TooltipRow
- label={`${t('Longitude and Latitude')}: `}
Review Comment:
I could see endless debate about translating colons and spaces... I'm not sure if I have strong feelings, but I can't help but wonder if strings like "Longitude and Latitude" might be recycled elsewhere, whereas they're not as reusable with the `: ` appended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
artemonsh commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1342313898
@michael-s-molina could you take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1063105231
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/Arc.jsx:
##########
@@ -37,11 +37,13 @@ function setTooltipContent(formData) {
return o => (
<div className="deckgl-tooltip">
<TooltipRow
- label={t('Start (Longitude, Latitude): ')}
+ // eslint-disable-next-line prefer-template
+ label={t('Start (Longitude, Latitude)' + ': ')}
Review Comment:
I guess this _could_ be a template string, but I don't particularly mind this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353669872
This generally looks good to me! I added a couple clarifying questions. In general, there seems like only one real pint of contention, which is that I'm not sure we want to include the colon-space combo in the translated strings, as the word(s) without the punctuation may provide utility in other settings. For example, `name: ` is translated, but we might just want to leverage `name` which is _probably_ already translated. I think this applies to several instances. Curious if others with experience in translations (e.g. @geido @ktmud @etr2460) might feel differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh closed pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
artemonsh closed pull request #22150: chore: Localization of several charts and elements
URL: https://github.com/apache/superset/pull/22150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1050028008
##########
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx:
##########
@@ -224,9 +224,12 @@ export class Tabs extends React.PureComponent {
title: t('Delete dashboard tab?'),
content: (
<span>
- Deleting a tab will remove all content within it. You may still
- reverse this action with the <b>undo</b> button (cmd + z) until you
- save your changes.
+ {t(
Review Comment:
I wonder if template literals would make this block a little more legible/parsable. Not a dealbreaker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353686047
@rusackas According to this [article](https://ux.shopify.com/how-to-concatenate-localized-strings-mindfully-bcc7b6d4961a) it seems sometimes the punctuation could also be translated. Check the **Punctuation** section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1353702216
> @rusackas According to this [article](https://ux.shopify.com/how-to-concatenate-localized-strings-mindfully-bcc7b6d4961a) it seems sometimes the punctuation could also be translated. Check the **Punctuation** section.
Makes sense... good enough for me. I'll give this my approval, but would love input on the other open questions, and more opinions on the matter before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1049987972
##########
superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx:
##########
@@ -259,9 +259,11 @@ function AnnotationList({
<span>{t('Annotation Layer %s', annotationLayerName)}</span>
<span>
{hasHistory ? (
- <Link to="/annotationlayer/list/">Back to all</Link>
+ <Link to="/annotationlayermodelview/list/">
+ {t('Back to all')}
+ </Link>
) : (
- <a href="/annotationlayer/list/">Back to all</a>
+ <a href="/annotationlayermodelview/list/">{t('Back to all')}</a>
Review Comment:
Can you explain the URI changes here? Not sure if this is bycatch (explanation would be helpful), or somehow related to the translation effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #22150:
URL: https://github.com/apache/superset/pull/22150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1373149062
Approved CI to run. Fingers crossed!
Latest changes seem fine too.
I'll circle back to merge this if CI passes. If it doesn't, nag me here or on Slack, and we'll sort it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh commented on a diff in pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
artemonsh commented on code in PR #22150:
URL: https://github.com/apache/superset/pull/22150#discussion_r1053356421
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.jsx:
##########
@@ -57,7 +58,7 @@ function setTooltipContent(formData) {
return (
<div className="deckgl-tooltip">
{o.object.name && (
- <TooltipRow label="name: " value={`${o.object.name}`} />
+ <TooltipRow label={t('name: ')} value={`${o.object.name}`} />
Review Comment:
Totally agree
##########
superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx:
##########
@@ -259,9 +259,11 @@ function AnnotationList({
<span>{t('Annotation Layer %s', annotationLayerName)}</span>
<span>
{hasHistory ? (
- <Link to="/annotationlayer/list/">Back to all</Link>
+ <Link to="/annotationlayermodelview/list/">
+ {t('Back to all')}
+ </Link>
) : (
- <a href="/annotationlayer/list/">Back to all</a>
+ <a href="/annotationlayermodelview/list/">{t('Back to all')}</a>
Review Comment:
I don't know how it happened :( Changed back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh closed pull request #22150: chore: Localization of several charts and elements
Posted by GitBox <gi...@apache.org>.
artemonsh closed pull request #22150: chore: Localization of several charts and elements
URL: https://github.com/apache/superset/pull/22150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh commented on pull request #22150: chore: Localization of some charts and elements
Posted by GitBox <gi...@apache.org>.
artemonsh commented on PR #22150:
URL: https://github.com/apache/superset/pull/22150#issuecomment-1330776729
@villebro take a look please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org