You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Anders Wallgren (JIRA)" <ji...@apache.org> on 2007/02/19 09:23:05 UTC

[jira] Created: (HTTPCORE-46) Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?

Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?
---------------------------------------------------------------------------

                 Key: HTTPCORE-46
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-46
             Project: HttpComponents Core
          Issue Type: Bug
          Components: HttpCore NIO
    Affects Versions: 4.0-alpha4
            Reporter: Anders Wallgren
             Fix For: 4.0-alpha4


in stopWorkers, shouldn't you call interrupt before join when shutting down the threads, so they don't linger, waiting for some timeout?  Or is it assumed that the socket/channel closure causes an immediate exit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCORE-46) Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?

Posted by "Anders Wallgren (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCORE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474248 ] 

Anders Wallgren commented on HTTPCORE-46:
-----------------------------------------

I was having problems, but it was my own doing, and I just happened to notice this.  Not a bug, I think.

> Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?
> ---------------------------------------------------------------------------
>
>                 Key: HTTPCORE-46
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-46
>             Project: HttpComponents Core
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.0-alpha4
>            Reporter: Anders Wallgren
>             Fix For: 4.0-alpha4
>
>
> in stopWorkers, shouldn't you call interrupt before join when shutting down the threads, so they don't linger, waiting for some timeout?  Or is it assumed that the socket/channel closure causes an immediate exit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Resolved: (HTTPCORE-46) Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCORE-46.
---------------------------------------

    Resolution: Invalid

> Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?
> ---------------------------------------------------------------------------
>
>                 Key: HTTPCORE-46
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-46
>             Project: HttpComponents Core
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.0-alpha4
>            Reporter: Anders Wallgren
>             Fix For: 4.0-alpha4
>
>
> in stopWorkers, shouldn't you call interrupt before join when shutting down the threads, so they don't linger, waiting for some timeout?  Or is it assumed that the socket/channel closure causes an immediate exit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCORE-46) Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCORE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474127 ] 

Oleg Kalnichevski commented on HTTPCORE-46:
-------------------------------------------

Hi Anders,

AbstractIOReactor#shutdown should cause an I/O reactor to terminate immediately, as it basically closes the underlying selector thus causing the termination of the I/O selection loop. Can you think of a case where this may be insufficient? Are you having problems shutting down I/O reactors?

Oleg



> Should AbstractMultiWorkerIOReactor.stopWorkers call interrupt before join?
> ---------------------------------------------------------------------------
>
>                 Key: HTTPCORE-46
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-46
>             Project: HttpComponents Core
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.0-alpha4
>            Reporter: Anders Wallgren
>             Fix For: 4.0-alpha4
>
>
> in stopWorkers, shouldn't you call interrupt before join when shutting down the threads, so they don't linger, waiting for some timeout?  Or is it assumed that the socket/channel closure causes an immediate exit?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org