You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2022/05/21 23:35:16 UTC

[Bug 66080] New: [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

            Bug ID: 66080
           Summary: [PATCH] XWPFNumbering.addAbstractNum uses abstract
                    numberings count as id
           Product: POI
           Version: 5.2.0-FINAL
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XWPF
          Assignee: dev@poi.apache.org
          Reporter: arakelov93@gmail.com
  Target Milestone: ---

Created attachment 38295
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38295&action=edit
fix adding id for new abstract numberings in XWPFNumbering.addAbstractNum

Method addAbstractNum(XWPFAbstractNum abstractNum) adds new numbering with id =
abstractNums.size(). But there can be a document, where numbering with this id
already exists. 
In the attached patch (git patch file), I added method that finds an id that is
not yet used in nmberings, and test that checks that all abstract numberings in
resulted document have unique ids.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

--- Comment #5 from PJ Fanning <fa...@yahoo.com> ---
added with r1901113

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

--- Comment #2 from Vladislav Arakelov <ar...@gmail.com> ---
Created attachment 38296
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38296&action=edit
test file for TestXWPFNumbering#testAddAbstractNum

Here it is, file that has one abstract numbering with id = 1

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

Vladislav Arakelov <ar...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

--- Comment #4 from Vladislav Arakelov <ar...@gmail.com> ---
Created attachment 38297
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38297&action=edit
new test for XWPFNumbering#addAbstractNum

And here is another version of the test, that does not require using external
.docx file

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #3 from PJ Fanning <fa...@yahoo.com> ---
I added r1901110

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 66080] [PATCH] XWPFNumbering.addAbstractNum uses abstract numberings count as id

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66080

--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
Comment on attachment 38295
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38295
fix adding id for new abstract numberings in XWPFNumbering.addAbstractNum

Can you attach the real NumberingWithOutOfOrderId.docx file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org